fix(instance): raise the instance timeout cap from 5 to 15 minutes - #35
Open
linmar wants to merge 1 commit into
Open
fix(instance): raise the instance timeout cap from 5 to 15 minutes#35linmar wants to merge 1 commit into
linmar wants to merge 1 commit into
Conversation
Radarr-shaped libraries with tens of thousands of items can take longer than five minutes to serialise /api/v3/movie (a Whisparr Eros instance with 30k scenes returns ~110 MB and needed 4.5 minutes while the app was busy), which made the library fetch fail on every cycle. The default stays at 15 s; only the validation ceiling moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the validation ceiling for the per-instance timeout from 5 to 15 minutes. Radarr-shaped libraries with tens of thousands of items can take longer than five minutes to serialise
/api/v3/movie: a Whisparr Eros instance with 30k scenes returns a ~110 MB payload and needed 4½ minutes while the app was busy, so the library fetch failed on every cycle at the current cap. The default stays 15 s; only the ceiling moves.Changes
internal/instance/service.go:maxTimeoutMs300000 → 900000 (comment explains why).Related issues
none
Test plan
make test)make lint— 0 issues)