Repository navigation
Conversation
👷 Deploy request for reframe-os pending review.Visit the deploys page to approve it
|
Contributor
👋 Thanks for your PR, @AFLAHAFI!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @AFLAHAFIBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
|
👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity. If you need help with this PR, please comment or ping a maintainer. |
chiragjangiir
left a comment
There was a problem hiding this comment.
Code Review & Accessibility: Expose selected state for overlay and font-weight presets
Diff Analysis & A11y Review:
- Accessible State Attributes: In
src/components/ImageOverlay.tsxandTextControls.tsx, addingaria-pressedand active styling classes to preset buttons allows assistive technologies to announce the active position (e.g.bottom-right) and font weight. - Storybook & Component Isolation: Adding Storybook stories in
ImageOverlay.stories.tsxandTextControls.stories.tsxwith realistic mock file data (image/pngdata URI) enables visual regression inspection. - Test Suite: New unit tests in
src/components/__tests__/PresetButtons.test.tsxverify click handling, selection toggling, and DOM attribute reflection.
Verification Assessment:
- High-quality accessibility fix with excellent storybook documentation and unit tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Image Overlay Position, Size and Opacity presets and Text Controls Font Weight buttons visually indicate the active choice but do not expose it to assistive technology.
This adds dynamic
aria-pressedto all 13 buttons using the same selection conditions as their existing styles. Position buttons also receive full accessible names. Preset values, event handlers and appearance are unchanged.Includes 21 React regression tests covering selection changes, size/opacity boundaries, keyboard activation, image removal and switching text overlays, plus Storybook stories for both components.
Validation:
bun run lint— passed.bunx tsc --noEmit— passed.bun run build— passed.bun run build-storybook— passed with bundle-size warnings.bun run test --run src/components/__tests__with repository dependencies — failed before tests executed because React 19.3.0 and React DOM 19.2.8 do not match.node_modulesonly, all 22 component tests passed, including the 21 new regression tests. Those 21 tests failed against the original components. The original local dependency was restored; no dependency or lockfile changes are included.Firefox, Safari, physical touch devices, screen-reader speech, video export, the broader test suite and Chromatic were not tested.
AI assistance: OpenAI Codex assisted with investigation, implementation, regression tests, local browser checks, recording and this description. I reviewed the implementation, review report and recording before submission.
Related Issue
Closes #1769
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link:
Reframe-1769-Demo.mp4
The recording shows the working controls and keyboard interaction. The demonstration's attribute inspector is not part of the application changes.
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in