-
Notifications
You must be signed in to change notification settings - Fork 74
Add xy.tooltip(mode="x"): a shared-axis tooltip with cursor and active dots #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -38,6 +38,7 @@ primitive or structural descendant is a separate DOM element. | |||||
| | `tooltip_row` | One tooltip field row | | ||||||
| | `tooltip_label` | One tooltip field label | | ||||||
| | `tooltip_value` | One formatted tooltip value | | ||||||
| | `tooltip_cursor` | Line across the plot at the shared-tooltip band coordinate (`xy.tooltip(mode="x")`) | | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: The Prompt for AI agents
Suggested change
|
||||||
| | `modebar` | Mode/tool bar container | | ||||||
| | `modebar_drag_handle` | Draggable grip revealed beside the toolbar | | ||||||
| | `modebar_control_group` | Selection, pan, and export control group | | ||||||
|
|
@@ -358,8 +359,8 @@ apply it with. Rather than leave that to be discovered, it is a contract: | |||||
| | --- | --- | --- | --- | | ||||||
| | mark / axis `style=` | yes | yes | yes | | ||||||
| | chart-level `style=` (design tokens) | yes | yes | yes | | ||||||
| | `styles={slot: {...}}` | yes, all 48 slots | text subset, 9 slots | text subset, 9 slots | | ||||||
| | `class_names={slot: "..."}` | yes, all 48 slots | dropped | dropped | | ||||||
| | `styles={slot: {...}}` | yes, all 49 slots | text subset, 9 slots | text subset, 9 slots | | ||||||
| | `class_names={slot: "..."}` | yes, all 49 slots | dropped | dropped | | ||||||
| | `custom_css=` | yes | raises | raises | | ||||||
| | `xy.legend(style=...)` | yes | 6 keys | 6 keys | | ||||||
| | `xy.colorbar(style=...)` | yes | dropped | dropped | | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Name both band modes in the slot description.
The slot also serves
xy.tooltip(mode="y"), where the cursor is a horizontal line.spec/api/styling.mdLine 719 already spells both modes. Align this row with it.📝 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents