Make AppHarness dependencies installable - #7008
Open
harsh21234i wants to merge 3 commits into
Open
Conversation
Contributor
Greptile SummaryThe PR makes
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| reflex/testing.py | Replaces the eager uvicorn import with guarded lazy imports across all runtime uses, resolving the previously reported production harness NameError. |
| pyproject.toml | Adds the testing extra containing the three optional AppHarness dependencies. |
| tests/units/test_testing.py | Adds regression coverage confirming that importing reflex.testing does not bind uvicorn at module load. |
| uv.lock | Synchronizes the package lock metadata with the new testing extra. |
Reviews (3): Last reviewed commit: "Merge branch 'main' into fix/6974-testin..." | Re-trigger Greptile
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #6974 by making reflex.testing usable from a clean published Reflex installation.
Changes
Removed the top-level uvicorn import from reflex.testing.
Added lazy imports with actionable installation messages.
Added a reflex[testing] extra containing:
Updated uv.lock.
Added a regression test for importing reflex.testing without test dependencies.
Added a changelog fragment.
Testing