fix(provider-openverse,provider-artic): respect upstream page-size ceilings - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two providers sent page sizes their upstream APIs reject, so they failed under core's default fusion pool (
fetchLimit = limit × poolFactor, up to 100).401 {"detail":"page_size may not exceed 20 for anonymous requests"}, so every anonymous Openverse search with default settings failed. The provider now capspage_sizeat 20 when no token is configured, as the last step before the request, soproviderOptions.pageSizecannot re-exceed it. With a token, behaviour is unchanged.limitis capped at 100, the API's per-page maximum (403 {"error":"Invalid limit"}above it). Core's pool never exceeds 100, but a caller-suppliedlimitabove 100 did.Found while acceptance-testing
@refkit/dsh-pluginin a live DeepSeek Harness session: the card showedopenverse: openverse search failed: 401on every search. Wikimedia Commons (gsrlimit=100) was probed too and accepts it.The weekly live-smoke did not catch this because its Openverse searches request fewer than 20 items.
Verification
pageSizeoption 50 → 20; token: 24 → 24), Openverse audio (no token: 24 → 20), Art Institute (150 → 100, 12 → 12). They failed before the fix and pass after.pnpm typecheck,pnpm lint,pnpm test:run: 516 passed, 23 skipped (live smokes).@refkit/provider-openverseand@refkit/provider-artic.