Skip to content

fix(antd, mantine): respect notification type in providers (#7477) - #7508

Open
sloemo01 wants to merge 2 commits into
refinedev:mainfrom
sloemo01:fix/notification-type-antd-mantine
Open

sloemo01 wants to merge 2 commits into
refinedev:mainfrom
sloemo01:fix/notification-type-antd-mantine

Conversation

@sloemo01

@sloemo01 sloemo01 commented Jul 25, 2026 •

Copy link
Copy Markdown

Fixes #7477

Summary of Changes:

  • @refinedev/antd: Updated useNotificationProvider to call notification.success or notification.error when a notification type is passed, preventing Ant Design from ignoring type when passed inside generic notification.open(). Updated corresponding unit test assertions.
  • @refinedev/mantine: Updated useNotificationProvider so neutral or unspecified notification types no longer default to red error icons/styles.

@changeset-bot

changeset-bot Bot commented Jul 25, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7291190

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/antd Patch
@refinedev/mantine Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sloemo01 sloemo01 changed the title fix(antd, mantine): respect notification type in providers fix(antd, mantine): respect notification type in providers (#7477) Jul 25, 2026
@stale

stale Bot commented Sep 23, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix This will not be worked on label Sep 23, 2026
@sloemo01
sloemo01 force-pushed the fix/notification-type-antd-mantine branch from fde5bec to 7291190 Compare September 28, 2026 00:49
@stale stale Bot removed the wontfix This will not be worked on label Sep 28, 2026
@sloemo01

Copy link
Copy Markdown
Author

Rebased onto current main and pushed: 72911909333. The branch was four commits behind (a version-packages release, its merge, and two core PRs), none of them touching this diff, so the patch carried over with no conflicts.

GitHub marked this stale on Sep 23, which puts an auto-close at the end of the month if nothing happens. The fix for #7477 is still absent from main, so this keeps it current for whenever it gets picked up.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] notification type is not respected in @refinedev/antd and @refinedev/mantine

1 participant