Repository navigation
Add TB to the FIFO quota units and make it the default (#253) - #257
Merged
Merged
Conversation
atimin
approved these changes
Nov 2, 2026
The quota size selector stopped at GB and defaulted to MB, so a value typed as TB could set a much smaller FIFO quota. Add a decimal TB factor, offer it for the quota only, and select it for a new quota. Existing quotas keep the unit picked by calcBestFactor, and Max Block Size keeps its B to GB units with the MB default.
AnthonyCvn
force-pushed
the
253-fifo-quota-tb
branch
from
November 3, 2026 18:12
6642e8d to
e698544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature (UI): improved bucket quota settings form.
What was changed?
The quota size selector now offers TB in addition to B, KB, MB, and GB, and new quotas default to 1 TB. Quota size is hidden when the quota type is NONE and shown only for FIFO or HARD, with a default of 1 TB pre-filled when the type is first switched to an active state. Quota size is validated on submit and non-integer input shows "Quota size must be a whole number". The settings modal now discards unsaved edits on close, and the Create/Update button shows a loading spinner while the request is in flight.
Related issues
No
Does this PR introduce a breaking change?
No. Stored quota values and Max Block Size behave as before.
Other information: