fix: support rich:video (transcoded external media) and CMAF format#549
Open
ddmunhoz wants to merge 1 commit intoredlib-org:mainfrom
Open
fix: support rich:video (transcoded external media) and CMAF format#549ddmunhoz wants to merge 1 commit intoredlib-org:mainfrom
ddmunhoz wants to merge 1 commit intoredlib-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where Gifs and other third-party video providers (flagged by Reddit as rich:video) fail to load or display a video player.
The problem revolves around Reddit has shifted how it handles external video embeds. Instead of just providing an oembed/iframe, it now transcodes many of these videos into its own v.redd.it infrastructure maybe for better mobile perf ? who knows ? These new transcodes differ from standard Reddit videos in two ways:
Because Redlib was looking specifically for DASH_ in both its regex logic and its proxy routing, these videos were being ignored or resulting in 404/403 errors when the browser tried to load them without the proxy.
Overall the changes are:
I tested on r/highqualitygifs and r/gifs, which appeared to be the biggest "offenders" using the CMAF container. Everything clicks.
Fix: #20
Simpler/safer approach over PR: #507 which focuses on fixing one edge case while adding a lot of dependencies/brittle code, since any API change will break this specific implementation.