Repository navigation
fix(mcp): explain memory fragmentation interpretation - #1342
Draft
joshrotenberg wants to merge 2 commits into
Draft
joshrotenberg wants to merge 2 commits into
joshrotenberg wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append general memory interpretation guidance to
redis_health_checkandredis_memory_stats: consider absolute byte overhead, allocator metrics and prior peaks, especially for small current allocation. The note explains that a high fragmentation ratio alone does not establish a memory problem. Existing values, fallbacks and raw nested or unknown metrics stay intact. No cutoff, diagnosis, recalculation or extra Redis requests are added.This is a bounded part of #1218 and leaves #1218 open. FT.PROFILE formatting is separate.
Validation uses actual-tool synthetic RESP2/RESP3 fixtures, with exact command sequences and error boundaries. The same corpus against the original handlers passed the error test and failed the three note tests after verifying all 14 existing output prefixes. It now passes all four tests with minimal database/test-support features and all features. The catalog contract, formatting and strict all-target/all-feature Clippy pass. No live memory-pressure claim is made.
Independent source review found no actionable findings at 76cd4c0. Hosted unit tests, integration tests and Linux/macOS/Windows builds pass at that head. Security Audit and advisory checks fail on the unchanged lockfile; the bans/licenses/sources sibling job was cancelled.
Cargo.lock is unchanged. Keep this draft for the separate #1335 security update, branch refresh and current-head checks/review after that refresh.