Skip to content

fix(mcp): explain JSON index schema choices after creation - #1341

Draft
joshrotenberg wants to merge 2 commits into
mainfrom
fix/mcp-ft-create-json-guidance-1218
Draft

joshrotenberg wants to merge 2 commits into
mainfrom
fix/mcp-ft-create-json-guidance-1218

Conversation

@joshrotenberg

@joshrotenberg joshrotenberg commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

After a successful FT.CREATE on JSON, the result now adds informational notes when relevant: supplied fields without aliases get a simple-query-name explanation, and JSON TAG fields without separators get the whole-string/array-path/explicit-splitting distinction. Field names are aggregated. The notes use only the requested schema and make no data or metadata queries.

The description now treats aliases as optional, explains limited JSONPath query parsing, and distinguishes HASH's comma default from JSON's lack of a default TAG separator. Wire arguments, schema shape, case handling, optional aliases/separators, errors, skip text and FT.ALTER runtime are preserved. Successful drop/recreate retains its existing summary and gains notes when applicable.

Bounded coverage for #1218; leaves #1218 open. The already-correct expert-search skill and explicit-comma fixture are unchanged.

Validation:

  • Identical corpus on old handler: 3 passed / 5 failed. Updated minimal and all-feature runs: 8 passed each, none ignored or filtered out.
  • Synthetic actual-tool cases cover RESP2/RESP3. Pinned Redis 8.6.7, Search 80608 and RedisJSON 80600 live controls cover RESP2 only: alias-free creation, aliased search, whole strings, comma/custom separators, array paths and HASH defaults.
  • Targeted catalog baseline contract, formatting and strict all-target/all-feature Clippy pass.

Cargo.lock is unchanged. Keep this draft for independent review, the separate security update, refresh onto repaired main and validation at the current head.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant