Repository navigation
fix(mcp): explain JSON index schema choices after creation - #1341
Draft
joshrotenberg wants to merge 2 commits into
Draft
joshrotenberg wants to merge 2 commits into
joshrotenberg wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful FT.CREATE on JSON, the result now adds informational notes when relevant: supplied fields without aliases get a simple-query-name explanation, and JSON TAG fields without separators get the whole-string/array-path/explicit-splitting distinction. Field names are aggregated. The notes use only the requested schema and make no data or metadata queries.
The description now treats aliases as optional, explains limited JSONPath query parsing, and distinguishes HASH's comma default from JSON's lack of a default TAG separator. Wire arguments, schema shape, case handling, optional aliases/separators, errors, skip text and FT.ALTER runtime are preserved. Successful drop/recreate retains its existing summary and gains notes when applicable.
Bounded coverage for #1218; leaves #1218 open. The already-correct expert-search skill and explicit-comma fixture are unchanged.
Validation:
Cargo.lock is unchanged. Keep this draft for independent review, the separate security update, refresh onto repaired main and validation at the current head.