Repository navigation
fix(mcp): report JSON array mutation no-ops - #1339
Draft
joshrotenberg wants to merge 2 commits into
Draft
joshrotenberg wants to merge 2 commits into
joshrotenberg wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON.ARRAPPEND, JSON.ARRINSERT and JSON.ARRTRIM reported new lengths or trimming for nil, empty and null-only replies. These replies now produce explicit no-op text. Mixed results, valid zero lengths, existing success output and server errors are preserved. The reply-only check adds no Redis queries or key-existence assumptions.
Coverage for #1338; leaves #1215 open. This branch starts from main independently of #1336 and contains no numeric decoder changes.
The test target checks actual MCP tools through synthetic RESP2/RESP3 replies and one isolated Redis 8.6.7 / RedisJSON 80600 container pinned by digest. Live checks compare complete stored JSON for no-ops, mixed/positive mutations, destructive trim-to-empty and already-empty zero controls, plus wrong-type errors. CI explicitly runs the live test; fixture failures fail it.
Validation:
Cargo.lock is unchanged. Keep this PR in draft for independent review and hosted validation.