Skip to content

fix RESP3 mismatches#471

Open
mgravell wants to merge 10 commits intomasterfrom
marc/resp3
Open

fix RESP3 mismatches#471
mgravell wants to merge 10 commits intomasterfrom
marc/resp3

Conversation

@mgravell
Copy link
Copy Markdown
Collaborator

@mgravell mgravell commented May 1, 2026

A few commands give different result shapes between RESP2 and RESP3, and require custom processing; this PR fixes those, making them work with either shape, interchangeably; usually this means arrays becoming maps, which by itself would be fine, but: the actual nesting/indenting/etc is changed at the same time - for example, a single flat array with a "stride" might become a jagged nesting of map[key, array]

  • streams
  • time-series
  • search
  • json
  • spell-checking

To ensure future compliance, we change [RunPerProtocol] to be implicit (RESP2+RESP3) on all integration tests.

Remaining faults:

  • search with cursor
  • search with profile

Note

Medium Risk
Touches core response parsing for multiple Redis modules to reconcile RESP2 vs RESP3 shape differences (arrays vs maps and changed nesting), which can impact runtime deserialization across many commands if any edge case is missed.

Overview
Improves RESP3 compatibility by normalizing response parsing across modules where RESP3 changes the shape/nesting of results (maps vs arrays).

JSON commands now use shared parsers for JSON.TYPE and JSON.NUMINCRBY so RESP2 (stringified JSON) and RESP3 (typed arrays/wrapping) both work.

ResponseParser is expanded to handle RESP3-specific encodings for TimeSeries (MGET/MRANGE incl. metadata), Streams (XREAD/XREADGROUP map form), Search (FT.SEARCH/FT.AGGREGATE map form), and SpellCheck output; Search results and aggregation results are updated to consume the new unified map parser.

Test infrastructure is adjusted to run integration tests under both RESP2 and RESP3 by default, and fixtures now infer/log server version from the first shared connection to support version-gated assertions.

Reviewed by Cursor Bugbot for commit 4d26ff6. Bugbot is set up for automated code reviews on this repo. Configure here.

@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 1, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

Comment thread src/NRedisStack/ResponseParser.cs Outdated
Comment thread src/NRedisStack/Search/AggregationResult.cs Outdated
Comment thread src/NRedisStack/ResponseParser.cs Outdated
Comment thread src/NRedisStack/Search/SearchResult.cs
Comment thread src/NRedisStack/Search/DataTypes/InfoResult.cs Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4d26ff6. Configure here.

Comment thread src/NRedisStack/ResponseParser.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant