Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4d26ff6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A few commands give different result shapes between RESP2 and RESP3, and require custom processing; this PR fixes those, making them work with either shape, interchangeably; usually this means arrays becoming maps, which by itself would be fine, but: the actual nesting/indenting/etc is changed at the same time - for example, a single flat array with a "stride" might become a jagged nesting of map[key, array]
To ensure future compliance, we change
[RunPerProtocol]to be implicit (RESP2+RESP3) on all integration tests.Remaining faults:
Note
Medium Risk
Touches core response parsing for multiple Redis modules to reconcile RESP2 vs RESP3 shape differences (arrays vs maps and changed nesting), which can impact runtime deserialization across many commands if any edge case is missed.
Overview
Improves RESP3 compatibility by normalizing response parsing across modules where RESP3 changes the shape/nesting of results (maps vs arrays).
JSON commands now use shared parsers for
JSON.TYPEandJSON.NUMINCRBYso RESP2 (stringified JSON) and RESP3 (typed arrays/wrapping) both work.ResponseParseris expanded to handle RESP3-specific encodings for TimeSeries (MGET/MRANGEincl. metadata), Streams (XREAD/XREADGROUPmap form), Search (FT.SEARCH/FT.AGGREGATEmap form), and SpellCheck output; Search results and aggregation results are updated to consume the new unified map parser.Test infrastructure is adjusted to run integration tests under both RESP2 and RESP3 by default, and fixtures now infer/log server version from the first shared connection to support version-gated assertions.
Reviewed by Cursor Bugbot for commit 4d26ff6. Bugbot is set up for automated code reviews on this repo. Configure here.