Skip to content

Update password for mssql - #70

Open
dvalinrh wants to merge 3 commits into
masterfrom
msql_pwd
Open

dvalinrh wants to merge 3 commits into
masterfrom
msql_pwd

Conversation

@dvalinrh

Copy link
Copy Markdown
Contributor

Description

Changes the mssql password so it is accepted.

Before/After Comparison

Before: mssql installation was failing because the password was to simple
After: Installation of mssql is successful

Clerical Stuff

This closes #69
to close the issue out automatically.

Relates to JIRA: RPOPC-1559

Testing

Ran hammerdb after fix, now get results

connection,TPM,Start_Date,End_Date
10,243853,2026-09-25T14:30:40Z,2026-09-25T14:46:48Z
20,322724,2026-09-25T14:46:58Z,2026-09-25T15:03:11Z
40,383068,2026-09-25T15:03:21Z,2026-09-25T15:19:34Z

@dvalinrh
dvalinrh requested a review from frival September 25, 2026 18:52
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 58021131-8c74-4ffd-9d62-0eb8ce08ff22


Comment @coderabbitai help to get the list of available commands.

Comment thread hammerdb/install-script Outdated
Comment thread hammerdb/install-script Outdated
echo abcdefgh >> input
echo A2!bcdefgh >> input
echo A2!bcdefgh >> input

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't delete this input file after it's used, leaking credentials.

@frival frival left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two easy ones to fix then I'll LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mssql password is to simple

2 participants