Repository navigation
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5726 +/- ##
==========================================
- Coverage 78.97% 73.33% -5.65%
==========================================
Files 66 59 -7
Lines 723 570 -153
Branches 100 83 -17
==========================================
- Hits 571 418 -153
Misses 151 151
Partials 1 1
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
The container image build workflow finished with status: |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
The container image build workflow finished with status: |
|
fips nightly job is failing on unrelated test cases (report, mostly scaffolder actions). The other tests are all green. |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
/agentic_review |
Code Review by Qodo 1. New FIPS database and Redis tests all fail at setup
|
zdrapela
left a comment
There was a problem hiding this comment.
Overall, I think the Qodo findings about Redis are worth checking, and I'd try to minimize the duplication if possible. WDYT?
d639ae2 to
bfeb33a
Compare
|
/agentic_review |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
/test ? |
|
/test e2e-ocp-helm-nightly |
|
/agentic_review |
|
The container image build workflow finished with status: |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
/agentic_review |
fffab37 to
66f7c1f
Compare
|
/agentic_review |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
/retest |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
/test e2e-ocp-v4-22-fips-helm-nightly |
|
|
/agentic_review |
1 similar comment
|
/agentic_review |



Summary
Adds external PostgreSQL and Redis TLS connection tests for FIPS environment.
PostgreSQL:
ssl_groupstoX25519:prime256v1, but X25519 is not FIPS-approved (NIST FIPS 186-4)postgres-fips.yamlwith FIPS-compatible setting:ssl_groups: "prime256v1"fips_modeparameter toconfigure_external_postgres_db()Redis:
fips-compliance.spec.tsto validate TLS connectionTesting:
Which issue(s) does this PR fix
Evidence
Testing
How the change was tested: the commands that ran, their output, and what the checks would miss.
Merge Danger
Door: one-way or two-way (can we walk back through it?)
Blast radius:
How to revert
<revert command, flag to turn off, or rollback step>
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer