Skip to content

chore(deps): prune and refresh TechDocs Python requirements - #5451

Merged
nickboldt merged 3 commits into
mainfrom
RHIDP-17016-python-deps
Sep 18, 2026
Merged

nickboldt merged 3 commits into
mainfrom
RHIDP-17016-python-deps

Conversation

@nickboldt

Copy link
Copy Markdown
Member

Summary

  • Prune python/requirements.in to mkdocs-techdocs-core==1.7.1 plus Hermeto-safe caps on urllib3 / platformdirs (setuptools_scm major conflict with python-dateutil sdists).
  • Replace duplicated runtime pins in requirements-build.in with real build-system deps only.
  • Regenerate hashed lockfiles: bump transitive deps (mkdocs 1.6.1, certifi, requests, urllib3 2.4.0, etc.) while keeping techdocs-core pins (pymdown-extensions==11.0.1, material 9.7.7, …).

Test plan

  • Local venv install of both lockfiles; mkdocs --version and techdocs_core import
  • Minimal Containerfile smoke (UBI nodejs-24 + python3.12-devel) mirroring techdocs pip install stage
  • hermeto fetch-deps with python/hermeto_github.json succeeded
  • Upstream PR image / CI build
  • Matching midstream pins when syncing downstream

Ref: https://redhat.atlassian.net/browse/RHIDP-17016

Generated-by: cursor

Slim requirements.in to mkdocs-techdocs-core plus Hermeto-safe caps, and
keep requirements-build.in as real build-system deps only. Regenerated
hashed lockfiles bump transitive packages (mkdocs, certifi, requests, etc.)
while respecting techdocs-core pins and setuptools_scm<8 for sdist builds.

https://redhat.atlassian.net/browse/RHIDP-17016

Generated-by: cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci
openshift-ci Bot requested review from josephca and polasudo September 18, 2026 17:57
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.04%. Comparing base (b4eab29) to head (a427d8e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5451       +/-   ##
===========================================
- Coverage   74.21%   64.04%   -10.17%     
===========================================
  Files          69       57       -12     
  Lines         799      573      -226     
  Branches      125       99       -26     
===========================================
- Hits          593      367      -226     
  Misses        205      205               
  Partials        1        1               
Flag Coverage Δ
rhdh 64.04% <ø> (-10.17%) ⬇️
Components Coverage Δ
Backend plugins ∅ <ø> (∅)
Backend app 71.91% <ø> (ø)
Frontend app 60.50% <ø> (ø)
Plugin utils ∅ <ø> (∅)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4eab29...a427d8e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickboldt
nickboldt requested review from JessicaJHee and kim-tsao and removed request for josephca September 18, 2026 17:59
@github-actions

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: failure.

tomlkit (pulled in by hatchling) builds with poetry-core; without it in
requirements-build.txt, offline sdist installs fail under Hermeto.

https://redhat.atlassian.net/browse/RHIDP-17016

Generated-by: cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
@nickboldt

Copy link
Copy Markdown
Member Author

Follow-up for the hermetic image build failure (No matching distribution found for poetry-core>=1.0.0a9 when installing tomlkit / hatchling from sdist under Hermeto):

fdfe708f4 adds poetry-core to requirements-build.in / .txt so offline builds can satisfy tomlkit's build-system requirement.

@github-actions

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: failure.

pluggy 1.6+ requires setuptools-scm>=8 to build from sdist, which
conflicts with our setuptools_scm<8 pin (python-dateutil / hatch-vcs).
Pin pluggy to 1.5.x and add calver for trove-classifiers sdists.

https://redhat.atlassian.net/browse/RHIDP-17016

Generated-by: cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
@nickboldt

Copy link
Copy Markdown
Member Author

Next hermetic failure after poetry-core:

ERROR: No matching distribution found for setuptools-scm>=8.0

while building pluggy==1.6.0 (via hatchling). That conflicts with our intentional setuptools_scm<8 pin for python-dateutil / hatch-vcs.

Also missing: calver (build-system require of trove-classifiers).

follow-up commit:

  • pin pluggy>=1.0,<1.6 → resolves to 1.5.0 (build needs setuptools-scm>=6.2.3 only)
  • add calver to requirements-build.in

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@nickboldt
nickboldt merged commit b8a7f51 into main Sep 18, 2026
10 of 12 checks passed
@nickboldt
nickboldt deleted the RHIDP-17016-python-deps branch September 18, 2026 21:07
@nickboldt

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.10
/cherry-pick release-1.9

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@nickboldt: new pull request created: #5453

Details

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@nickboldt: new pull request created: #5454

Details

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants