fix(e2e): scope the pods status chip to its deployment accordion [release-1.9] - #5445
Closed
gustavolira wants to merge 2 commits into
Closed
gustavolira wants to merge 2 commits into
gustavolira wants to merge 2 commits into
Conversation
verifyPodLogs located the deployment's pod-count chip with a page-wide span[aria-label="Status ok"] nth(4). The page-wide chip count depends on what the cluster happens to contain and on the user's RBAC visibility; the current Kubernetes tab renders only 4 chips (2 on the cluster summary, 2 on the deployment), so nth(4) waits for a fifth chip that no longer exists and both kubernetes-rbac tests time out (RHDHBUGS-3775). Locate the chip inside the deployment's own accordion summary button instead, matched by its accessible name, so the assertion is unaffected by other resources appearing or disappearing. Verified against the accessibility snapshots (error-context.md) of the failed release-1.9-e2e-gke-operator-nightly runs: the scoped locator resolves in both the permitted and the restricted user scenarios. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… accordion Review hardening: exact accessible-name matching, and filter the nested same-named buttons by the chip they must contain instead of taking the first DOM match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Contributor
|
The container image build workflow finished with status: |
Member
Author
|
Folded into #5441 (same branch target, complementary fix) so one gke-operator run can validate showcase-rbac going fully green. The two commits were cherry-picked there verbatim. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the two remaining
showcase-rbacfailures in the release-1.9 gke-operator nightly (RHDHBUGS-3775):Root cause
KubernetesPage.verifyPodLogspicked the deployment's pod-count chip positionally: the 5thStatus okchip on the whole page. The page-wide chip count depends on what the cluster contains and on the user's RBAC visibility. The current Kubernetes tab renders only 4 chips (2 on themy-clustersummary + 2 on thetopology-testdeployment row — confirmed in the accessibility snapshots of the failed runs), sonth(4)waits forever.Fix
Locate the chip inside the deployment's own accordion summary (
getByRole("button", { name: \${text} Deployment namespace: …` })) and filter by the pod-count text, per the repo's locator rules (no positionalnthwithout semantic context). Verified against theerror-context.md` snapshots of both failing scenarios (permitted and restricted user) from this run: the scoped locator resolves in both.Note: main removed this spec in #4795 (wrapper-plugin test migration), so this fix is release-1.9 only.
Together with #5441, this should turn
showcase-rbacon the gke-operator nightly fully green (8 failures → 2 → 0).🤖 Generated with Claude Code