fix(ci): correct default RBAC GitHub App env vars - #5442
Merged
openshift-merge-bot[bot] merged 1 commit intoSep 18, 2026
Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-merge-bot[bot] merged 1 commit into
Conversation
The default block (used whenever the per-run prefix rotation finds an incomplete _RBAC_<n> secret set) assigned the OPERATOR app's CLIENT_SECRET to GITHUB_APP_PRIVATE_KEY_RBAC — an app JWT can never be minted from a client secret, so GitHub discovery and bulk-import fail with 401 Unauthorized whenever the defaults kick in. GITHUB_APP_CLIENT_SECRET_RBAC was also missing from the block. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5442 +/- ##
===========================================
- Coverage 74.21% 64.04% -10.17%
===========================================
Files 69 57 -12
Lines 799 573 -226
Branches 125 99 -26
===========================================
- Hits 593 367 -226
Misses 205 205
Partials 1 1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
openshift-merge-bot
Bot
merged commit Sep 18, 2026
b4eab29
into
redhat-developer:main
25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
In
.ci/pipelines/env_variables.sh, the default RBAC GitHub App block (used whenever the per-run prefix rotation finds an incomplete_RBAC_<n>secret set — seeoverride_github_app_env_with_prefix) has two bugs:GITHUB_APP_PRIVATE_KEY_RBACreadsGITHUB_APP_CLIENT_SECRET_OPERATOR— an app JWT can never be minted from a client secret, so every GitHub App call from the RBAC namespace fails with401 Unauthorized(breaking catalog discovery and bulk-import) whenever the defaults kick in.GITHUB_APP_CLIENT_SECRET_RBACis missing from the block entirely.Same fix as the release-1.9 counterpart in #5441 (where the 2026-09-18 gke-operator nightly showed the resulting
Fetching repositories with token from token failed 401 Unauthorized).🤖 Generated with Claude Code