Skip to content

fix(ci): correct default RBAC GitHub App env vars - #5442

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
gustavolira:fix/rbac-github-app-env-defaults
Sep 18, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
gustavolira:fix/rbac-github-app-env-defaults

Conversation

@gustavolira

Copy link
Copy Markdown
Member

Description

In .ci/pipelines/env_variables.sh, the default RBAC GitHub App block (used whenever the per-run prefix rotation finds an incomplete _RBAC_<n> secret set — see override_github_app_env_with_prefix) has two bugs:

  • GITHUB_APP_PRIVATE_KEY_RBAC reads GITHUB_APP_CLIENT_SECRET_OPERATOR — an app JWT can never be minted from a client secret, so every GitHub App call from the RBAC namespace fails with 401 Unauthorized (breaking catalog discovery and bulk-import) whenever the defaults kick in.
  • GITHUB_APP_CLIENT_SECRET_RBAC is missing from the block entirely.

Same fix as the release-1.9 counterpart in #5441 (where the 2026-09-18 gke-operator nightly showed the resulting Fetching repositories with token from token failed 401 Unauthorized).

🤖 Generated with Claude Code

The default block (used whenever the per-run prefix rotation finds an
incomplete _RBAC_<n> secret set) assigned the OPERATOR app's CLIENT_SECRET
to GITHUB_APP_PRIVATE_KEY_RBAC — an app JWT can never be minted from a
client secret, so GitHub discovery and bulk-import fail with 401
Unauthorized whenever the defaults kick in. GITHUB_APP_CLIENT_SECRET_RBAC
was also missing from the block.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from josephca and zdrapela September 18, 2026 13:25
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.04%. Comparing base (24f9e3f) to head (7f5eea0).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5442       +/-   ##
===========================================
- Coverage   74.21%   64.04%   -10.17%     
===========================================
  Files          69       57       -12     
  Lines         799      573      -226     
  Branches      125       99       -26     
===========================================
- Hits          593      367      -226     
  Misses        205      205               
  Partials        1        1               
Flag Coverage Δ
rhdh 64.04% <ø> (-10.17%) ⬇️
Components Coverage Δ
Backend plugins ∅ <ø> (∅)
Backend app 71.91% <ø> (ø)
Frontend app 60.50% <ø> (ø)
Plugin utils ∅ <ø> (∅)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f9e3f...7f5eea0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@hopehadfield hopehadfield left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 18, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit b4eab29 into redhat-developer:main Sep 18, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants