fix(intelligent-assistant): align Chat/Notebooks shell with PatternFly defaults - #5003
Merged
karthikjeeyar merged 7 commits intoSep 28, 2026
Conversation
…y defaults Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3733 Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ciiay
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
September 28, 2026 04:45
Changed Packages
|
9 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5003 +/- ##
==========================================
- Coverage 63.67% 63.65% -0.02%
==========================================
Files 2705 2705
Lines 106588 106578 -10
Branches 30023 30034 +11
==========================================
- Hits 67865 67843 -22
- Misses 36921 36933 +12
Partials 1802 1802
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Keep PF focusTrap enabled so the panel stays role="dialog" for e2e/a11y, and move initial focus to New chat so DrawerCloseButton no longer looks hovered while open. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Member
There was a problem hiding this comment.
Thanks @ciiay 🎉 I really appreciate the goal of aligning the Chat and Notebook shell with PF defaults, it should make the UI feel more consistent and improves the maintainability.
I have added one observation below, and rest all looks great!
…d bg Bring back a lean StyledChatbotFooter so the message bar tracks available pane width when sidebars collapse (override PF's 60rem cap) and matches the chatbot floating background. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Use PF's 90% footer width (without the 60rem cap) so Chat message input matches the scrollable log inset; keep 100% + side padding for compact. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…ding Drop percentage footer width; use full pane width with spacer--lg horizontal padding like the scrollable message log. Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
New changes are detected. LGTM label has been removed. |
Use MessageBox padding for Notebooks welcome/footer gutters and switch New chat to PencilAltIcon so Chat and Notebooks share one clean inset. Co-authored-by: Cursor <cursoragent@cursor.com>
…ll overrides Drop the redundant compact footer override, tighten comments, and align the conversation Rename icon with MCP edit. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align the Intelligent Assistant Chat and Notebooks shell with stock PatternFly Chatbot / Drawer APIs so PF updates stop fighting custom CSS. Removes footer/header chrome overrides where props suffice, shares plain icon-button rails, sets docked drawer width to PF's 480px (30rem), and fixes sticky hover on history close/expand controls (MenuToggle
aria-expanded, focus trap landing on DrawerCloseButton, and PF:focusmatching:hover).Fixed
UI after changes
rhdhbugs_3733.mp4
Test Plan
Checklist
Note