feat(bulk-import): add if predicate gating - #4687
Open
debsmita1 wants to merge 1 commit into
Open
Conversation
debsmita1
requested review from
a team,
its-mitesh-kumar and
rm3l
as code owners
September 10, 2026 13:39
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4687 +/- ##
=======================================
Coverage 62.72% 62.72%
=======================================
Files 2636 2636
Lines 105422 105422
Branches 29526 29513 -13
=======================================
Hits 66125 66125
Misses 37458 37458
Partials 1839 1839
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
debsmita1
force-pushed
the
bi-if-predicate
branch
from
September 11, 2026 11:28
507c9eb to
50d83b9
Compare
Member
|
It looks like permission is disabled in the app config that the tests use. The test cases that check if bulk import is denied are not working, since there is no call to |
debsmita1
force-pushed
the
bi-if-predicate
branch
3 times, most recently
from
September 11, 2026 13:53
de7d573 to
b8f9c2d
Compare
Signed-off-by: Debsmita Santra <debsmita.santra@gmail.com>
debsmita1
force-pushed
the
bi-if-predicate
branch
from
September 11, 2026 14:01
b8f9c2d to
91fed90
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Resolves:
https://redhat.atlassian.net/browse/RHIDP-15542
Solution description:
bulk.importfrom resource permission (resourceType: 'bulk-import') to a feature-level BasicPermission with empty attributes, matching how authorization is actually enforced today.AddRepositoriesPagein the NFS flow; legacy (./legacy) still uses usePermission in BulkImportSidebarItem and shows a denied alert on direct navigation.Note: The previous resource permission provided no real resource-level authorization (every resourceRef was "bulk-import", no conditional rules, no getResources). It also blocked adoption of the NFS if predicate for conditional UI registration. The new model aligns permission definition, RBAC policy (bulk.import, use, allow), backend checks, and NFS visibility.
Screenshot:
✔️ Checklist