docs(#4652): clarify changeset bump guidance for type changes - #4653
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#4652): clarify changeset bump guidance for type changes#4653fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Refine the major/minor bump criteria in .fullsend/AGENTS.md to distinguish between runtime-breaking and TypeScript-only-breaking API changes. The previous guidance listed changed interfaces as major, which caused the review agent to repeatedly flag minor bumps on additive type changes that are TypeScript compile-time breaking but runtime/JSON-compatible. The updated guidance specifies major for changes that affect runtime behavior or remove capabilities (removed exports, narrowed types, removed fields), and minor as acceptable for additive or widening type changes on public interfaces that maintain runtime/JSON compatibility. This aligns with established repo practice (e.g., PR #4582) and eliminates the ambiguity that caused repeated false-positive missing-version-bump findings. Closes #4652
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine the major/minor bump criteria in .fullsend/AGENTS.md to distinguish between runtime-breaking and TypeScript-only-breaking API changes. The previous guidance listed changed interfaces as major, which caused the review agent to repeatedly flag minor bumps on additive type changes that are TypeScript compile-time breaking but runtime/JSON-compatible.
The updated guidance specifies major for changes that affect runtime behavior or remove capabilities (removed exports, narrowed types, removed fields), and minor as acceptable for additive or widening type changes on public interfaces that maintain runtime/JSON compatibility. This aligns with established repo practice (e.g., PR #4582) and eliminates the ambiguity that caused repeated false-positive missing-version-bump findings.
Closes #4652
Post-script verification
agent/4652-clarify-bump-guidance)c380e6b99bfdc49fd073ce3b27744ce06fbf473d..HEAD)