chore(#4441): remove electron-to-chromium resolution from app-defaults - #4607
Open
fullsend-ai-coder[bot] wants to merge 2 commits into
Open
chore(#4441): remove electron-to-chromium resolution from app-defaults#4607fullsend-ai-coder[bot] wants to merge 2 commits into
fullsend-ai-coder[bot] wants to merge 2 commits into
Conversation
fullsend-ai-coder
Bot
requested review from
a team,
christoph-jerolimov and
rohitkrai03
as code owners
September 8, 2026 11:17
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
=======================================
Coverage 62.58% 62.58%
=======================================
Files 2634 2634
Lines 105187 105187
Branches 29528 29525 -3
=======================================
Hits 65833 65833
Misses 37543 37543
Partials 1811 1811
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
|
/fs-fix rebase and resolve conflict. remove dependency from package.json and regenerate yarn.lock |
Contributor
Author
|
🤖 Finished Fix · ✅ Success · Started 11:04 AM UTC · Completed 11:17 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $1.33 |
Remove the pinned electron-to-chromium resolution (1.5.419) from the app-defaults workspace package.json. This was an unnecessary direct pin -- the package is only needed as a transitive dependency of browserslist and resolves correctly through the dependency tree without a resolution override. Regenerated yarn.lock accordingly; electron-to-chromium now resolves to 1.5.423 via its transitive consumer. Closes #4441
Rebased onto main to resolve merge conflict in package.json and yarn.lock. The electron-to-chromium resolution is removed from package.json (as intended by this PR); yarn.lock regenerated so electron-to-chromium resolves via the transitive dependency tree. Addresses review feedback on #4607
fullsend-ai-coder
Bot
force-pushed
the
agent/4441-remove-electron-to-chromium
branch
from
September 10, 2026 11:17
77d0879 to
fb73415
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the pinned electron-to-chromium resolution (1.5.419) from the app-defaults workspace package.json. This was an unnecessary direct pin -- the package is only needed as a transitive dependency of browserslist and resolves correctly through the dependency tree without a resolution override. Regenerated yarn.lock accordingly; electron-to-chromium now resolves to 1.5.423 via its transitive consumer.
Closes #4441
Post-script verification
agent/4441-remove-electron-to-chromium)a7a1b4aea40ea9bbcfe6b5e3761fc51153917a19..HEAD)