Skip to content

fix(update-overlay): validate plugin directories - #162

Merged
gashcrumb merged 2 commits into
redhat-developer:mainfrom
gashcrumb:fix/RHDHBUGS-3746-validate-plugin-directories
Sep 11, 2026
Merged

fix(update-overlay): validate plugin directories#162
gashcrumb merged 2 commits into
redhat-developer:mainfrom
gashcrumb:fix/RHDHBUGS-3746-validate-plugin-directories

Conversation

@gashcrumb

@gashcrumb gashcrumb commented Sep 10, 2026

Copy link
Copy Markdown
Member

Fixes RHDHBUGS-3746.

Validate every discovered plugin directory at the selected source commit before reconciling plugins-list.yaml. Stale npm metadata can therefore no longer add a removed path, such as plugins/dynamic-home-page, to an overlay workspace.

Adds an action-level regression test covering the stale legacy homepage directory.

Assisted-By: OpenCode
Signed-off-by: Stan Lewis <gashcrumb@gmail.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@gashcrumb

Copy link
Copy Markdown
Member Author

Once merged I'll create a PR like this change to fix the homepage workspace's plugin list.

Assisted-By: OpenCode

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@sonarqubecloud

Copy link
Copy Markdown

@gashcrumb

Copy link
Copy Markdown
Member Author

Once merged I'll create a PR like this change to fix the homepage workspace's plugin list.

Ah, there's already this PR that will take care of that.

@hopehadfield hopehadfield left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gashcrumb!

@gashcrumb
gashcrumb merged commit d19a524 into redhat-developer:main Sep 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants