You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: support release-2.1 in Lightspeed config sync - #3710
How to test changes / Special notes to the reviewer
Container Images
Container images are built and pushed to Quay automatically when relevant files change.
Image links will be posted in a PR comment once the push completes.
• Add release-2.1 to the nightly config-sync workflow.
• Detect changes in branch-specific paths and list the corresponding files in generated PRs.
Diagram
graph TD
A["Branch matrix"] --> B["Branch checkout"] --> C["Config sync"] --> D{"Which branch?"}
D -->|release-1.10| E["Lightspeed paths"] --> G["Change check"] --> H["Regenerate and PR"]
D -->|release-2.1| F["Assistant paths"] --> G
Loading
High-Level Assessment
Keep the existing matrix workflow and select change paths and PR file lists by branch. Separate workflows would duplicate the sync, regeneration, and PR logic for two closely related releases.
Files changed (1) +17 / -9
Other (1) +17 / -9
sync-lightspeed-configs.yamlSync release-2.1 with branch-specific change detection+17/-9
Sync release-2.1 with branch-specific change detection
• Adds release-2.1 to the workflow matrix. Checks legacy Lightspeed paths on release-1.10 and intelligent-assistant paths, including OKP, on release-2.1; generated PRs list the files appropriate to each branch.
The workflow invokes sync-lightspeed-configs.sh for release-1.10 with only --ref, so the
script uses its Intelligent Assistant repository default and output paths instead of the legacy
Lightspeed repository and configuration paths. When the 1.10 job runs, it fetches the ref from the
wrong upstream and cannot keep the distinct legacy configuration current; the later TARGET_REPO
assignment changes only the pull-request text, not the fetch.
ⓘ Recommendations generated based on similar findings in past PRs
Evidence
The workflow omits --repo from the sync invocation even though it identifies the legacy repository
later when constructing the pull-request description and checks legacy output paths. The script uses
the Intelligent Assistant repository unless --repo is passed and writes to Intelligent Assistant
paths; the rhdh-plugins migration documents distinct legacy Lightspeed and Intelligent Assistant
configuration contracts.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
The release-1.10 job does not select its legacy Lightspeed upstream, and the current script defaults to the Intelligent Assistant repository and output paths.
## Fix Focus Areas
- .github/workflows/sync-lightspeed-configs.yaml[50-61]
- hack/sync-lightspeed-configs.sh[8-18]
- hack/sync-lightspeed-configs.sh[207-210]
## Recommended Fix
Pass `--repo redhat-ai-dev/lightspeed-configs` when invoking the script for release-1.10, and ensure that invocation writes the legacy Lightspeed ConfigMap and example. Keep the Intelligent Assistant repository and paths for release-2.1, and check for changes against the paths each invocation actually writes.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Context sources
⚠️ Tickets: not configured — ticket URL found in PR but could not be fetched — check ticket provider credentials
The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
release-2.1to the list of allowable branchesWhich issue(s) does this PR fix or relate to
https://redhat.atlassian.net/browse/RHIDP-16806
PR acceptance criteria
How to test changes / Special notes to the reviewer
Container Images
Container images are built and pushed to Quay automatically when relevant files change.
Image links will be posted in a PR comment once the push completes.