Skip to content

ci: support release-2.1 in Lightspeed config sync - #3710

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
Jdubrick:codex/add-release-2.1-lightspeed-sync
Oct 5, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
Jdubrick:codex/add-release-2.1-lightspeed-sync

Conversation

@Jdubrick

@Jdubrick Jdubrick commented Oct 5, 2026

Copy link
Copy Markdown
Member

Description

  • Adds release-2.1 to the list of allowable branches
  • Adds handling for the lightspeed -> intelligent-assistant rebrand that occurred

Which issue(s) does this PR fix or relate to

https://redhat.atlassian.net/browse/RHIDP-16806

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

Container Images

Container images are built and pushed to Quay automatically when relevant files change.
Image links will be posted in a PR comment once the push completes.

@Jdubrick
Jdubrick requested a review from a team as a code owner October 5, 2026 17:44
@sonarqubecloud

sonarqubecloud Bot commented Oct 5, 2026

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Support release-2.1 in Lightspeed config sync

⚙️ Configuration changes ✨ Enhancement 🕐 10-20 Minutes

Grey Divider

AI Description

• Add release-2.1 to the nightly config-sync workflow.
• Detect changes in branch-specific paths and list the corresponding files in generated PRs.
Diagram

graph TD
  A["Branch matrix"] --> B["Branch checkout"] --> C["Config sync"] --> D{"Which branch?"}
  D -->|release-1.10| E["Lightspeed paths"] --> G["Change check"] --> H["Regenerate and PR"]
  D -->|release-2.1| F["Assistant paths"] --> G
Loading
High-Level Assessment

Keep the existing matrix workflow and select change paths and PR file lists by branch. Separate workflows would duplicate the sync, regeneration, and PR logic for two closely related releases.

Files changed (1) +17 / -9

Other (1) +17 / -9
sync-lightspeed-configs.yamlSync release-2.1 with branch-specific change detection +17/-9

Sync release-2.1 with branch-specific change detection

• Adds release-2.1 to the workflow matrix. Checks legacy Lightspeed paths on release-1.10 and intelligent-assistant paths, including OKP, on release-2.1; generated PRs list the files appropriate to each branch.

.github/workflows/sync-lightspeed-configs.yaml

@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Legacy Lightspeed sync stops working ✗ Dismissed
Description
The workflow invokes sync-lightspeed-configs.sh for release-1.10 with only --ref, so the
script uses its Intelligent Assistant repository default and output paths instead of the legacy
Lightspeed repository and configuration paths. When the 1.10 job runs, it fetches the ref from the
wrong upstream and cannot keep the distinct legacy configuration current; the later TARGET_REPO
assignment changes only the pull-request text, not the fetch.
Code

.github/workflows/sync-lightspeed-configs.yaml[53]

+          ./hack/sync-lightspeed-configs.sh --ref ${{ matrix.branch }}
Relevance

●●● Strong

Exact recent precedent accepted preserving legacy release-1.10 repository routing in this workflow.

PR-#3474

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The workflow omits --repo from the sync invocation even though it identifies the legacy repository
later when constructing the pull-request description and checks legacy output paths. The script uses
the Intelligent Assistant repository unless --repo is passed and writes to Intelligent Assistant
paths; the rhdh-plugins migration documents distinct legacy Lightspeed and Intelligent Assistant
configuration contracts.

rhdh-operator -> rhdh-plugins
.github/workflows/sync-lightspeed-configs.yaml[53-58]
.github/workflows/sync-lightspeed-configs.yaml[82-92]
hack/sync-lightspeed-configs.sh[8-18]
hack/sync-lightspeed-configs.sh[207-210]
hack/sync-lightspeed-configs.sh[7-9]
hack/sync-lightspeed-configs.sh[29-40]
hack/sync-lightspeed-configs.sh[48-56]
.github/workflows/sync-lightspeed-configs.yaml[50-58]
.github/workflows/sync-lightspeed-configs.yaml[76-87]
External repo: redhat-developer/rhdh-plugins, workspaces/intelligent-assistant/plugins/intelligent-assistant-backend/README.md [61-75]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The release-1.10 job does not select its legacy Lightspeed upstream, and the current script defaults to the Intelligent Assistant repository and output paths.

## Fix Focus Areas
- .github/workflows/sync-lightspeed-configs.yaml[50-61]
- hack/sync-lightspeed-configs.sh[8-18]
- hack/sync-lightspeed-configs.sh[207-210]

## Recommended Fix
Pass `--repo redhat-ai-dev/lightspeed-configs` when invoking the script for release-1.10, and ensure that invocation writes the legacy Lightspeed ConfigMap and example. Keep the Intelligent Assistant repository and paths for release-2.1, and check for changes against the paths each invocation actually writes.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
⚠️ Tickets: not configured — ticket URL found in PR but could not be fetched — check ticket provider credentials
✅ Compliance rules (platform): 14 rules
✅ Cross-repo context — repo relationships
  Explored: repo: redhat-developer/rhdh (sha: b4e0264e) — View relationship
  Explored: repo: redhat-developer/rhdh-plugins (sha: 1e44f63a) — View relationship
Review mode: Auto: ⚖️ Balanced: CI workflow behavior changes branch selection, synchronization paths, and generated PR content.

Grey Divider

Tip of the day
💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread .github/workflows/sync-lightspeed-configs.yaml
@rhdh-qodo-merge rhdh-qodo-merge Bot added enhancement New feature or request Bug fix labels Oct 5, 2026
@rhdh-qodo-merge

Copy link
Copy Markdown

Important

The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more

@openshift-ci openshift-ci Bot added the lgtm label Oct 5, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit e84b710 into redhat-developer:main Oct 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug fix enhancement New feature or request lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants