Repository navigation
Conversation
Member
Author
|
/agentic_review |
1 similar comment
Member
|
/agentic_review |
Code Review by QodoResolved findings 1.
|
rm3l
requested changes
Oct 5, 2026
rm3l
left a comment
Member
There was a problem hiding this comment.
The Qodo findings are also valid and worth fixing
Member
Author
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 4ab6108 |
rm3l
reviewed
Oct 12, 2026
NiallTwomey2
commented
Oct 15, 2026
rm3l
requested changes
Oct 16, 2026
NiallTwomey2
commented
Oct 16, 2026
NiallTwomey2
commented
Oct 16, 2026
NiallTwomey2
commented
Oct 16, 2026
…og-level to set verbosity
Signed-off-by: NiallTwomey2 <nialltwomey44@gmail.com>
…erability for run_cmd Signed-off-by: NiallTwomey2 <nialltwomey44@gmail.com>
NiallTwomey2
force-pushed
the
RHDHBUGS-2638-catalog-source-log-level
branch
from
October 20, 2026 11:22
f6d23e5 to
ff04aeb
Compare
rm3l
reviewed
Oct 28, 2026
Co-authored-by: Armel Soro <armel@rm3l.org>
|
rm3l
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
install-rhdh-catalog-source.shalways printed DEBUG, which made successful and failed runs too noisy.This adds
--log-level error|warn|info|debug(defaultinfo) and--debugas a shorthand for--log-level debug. DEBUG is hidden unless debug is requested.--helpis handled before cluster checks. On command failure, captured log lines are dumped when the ERR trap fires.Docs in
.rhdh/docs/installing-ci-builds.adocmention the quieter default and how to turn debug back on.Which issue(s) does this PR fix or relate to
PR acceptance criteria
.rhdh/scripts/install-rhdh-catalog-source.sh --helpExpect
--log-leveland--debugin Options, exit 0, no cluster/OLM errors..rhdh/scripts/install-rhdh-catalog-source.sh --log-level noisy --latestExpect
[ERROR] Unknown log level: noisyand usage..rhdh/scripts/install-rhdh-catalog-source.sh --latestExpect
[ERROR]only (for example OLM not installed). No[DEBUG]..rhdh/scripts/install-rhdh-catalog-source.sh --debug --latestExpect the same error plus
[DEBUG]lines (working dir, cluster detection).--log-level debug --latestshould match--debug --latest.Do not use
-vfor verbose;-vis still the RHDH version flag.Container Images
Container images are built and pushed to Quay automatically when relevant files change.
Image links will be posted in a PR comment once the push completes.