fix(dynamic-plugins): generate entries with enabled key - #224
hopehadfield merged 4 commits into
Conversation
Use enabled in CLI-generated plugin configuration and documentation examples instead of deprecated disabled. Refs: RHIDP-17293 Assisted-by: gpt-6-sol Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
davidfestal
left a comment
davidfestal
left a comment
There was a problem hiding this comment.
Do you want to update the package.json ad ChangeLog ?
|
I suspect you'll want to cherrypick this to the release-2.1 branch too. |
Refs: RHIDP-17293 Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
|
/cherry-pick release-2.1 |
|
@hopehadfield: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Refs: RHIDP-17293 Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
|
|
@hopehadfield: new pull request created: #227 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Summary
enabled: truerather than deprecateddisabled: falsewhenplugin devwrites its generated local configuration andplugin packageprints dynamic-plugin configuration.enabled: true.Related: RHIDP-17293. The installer deprecation warning is in rhdh-plugins#5023.
Validation
yarn lint:checkyarn prettier:checkyarn tscyarn jest --config node_modules/@backstage/cli-module-test-jest/config/jest.js --runInBand --coverage=false src/commands/dev/command.test.ts src/commands/package-dynamic-plugins/command.test.ts(67 tests passed)