fix: completion without textEdit removes the whitespace before the caret - #1667
Merged
angelozerr merged 1 commit intoSep 14, 2026
Conversation
Fixes redhat-developer#993 Signed-off-by: Siarhei Sauchuk <seregasavchuk@gmail.com>
Contributor
|
LGTM, thanks @sergeysavchuk ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A completion item with only
insertText(notextEdit) removes the whitespacebefore the caret when it is applied on a blank line.
The prefix start comes from
getWordRangeAt, which returns the PSI element atoffset - 1— on a blank line, the whitespace leaf. The existing guard onlyrejects a one character element, so
"\n\n"or"\n "gets through and thecompletion replaces it.
The fix returns
nullfor whitespace, which also restores the documentedfoo | bar -> nullcontract.Fixes #993