fix: Reschedule diagnostics refresh on modification-stamp mismatch - #1666
Merged
angelozerr merged 1 commit intoSep 14, 2026
Conversation
angelozerr
changed the title
Fixes: redhat-developer#1665 Since commit fa5764c, LSPDiagnosticsApplier.applyHighlights() silently drops the update when the document modification stamp has changed between collection and apply. Because OpenedDocument.updateDiagnostics() only calls scheduleRefresh when the diagnostic set actually changes, subsequent identical publishDiagnostics notifications are treated as unchanged and never re-applied, leaving stale squiggles in the editor. Fix: on stamp mismatch, reschedule a new refresh via scheduleRefresh() instead of returning. The existing coalesceBy() ensures rapid reschedules during continuous typing are coalesced, not piled up. Once the user stops typing, the stamp matches and diagnostics apply normally. Signed-off-by: azerr <azerr@redhat.com>
angelozerr
force-pushed
the
fix/diagnostics-stop-refreshing-after-dropped-update
branch
from
September 14, 2026 09:16
08f48c4 to
c7b4c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1665
Since commit fa5764c, LSPDiagnosticsApplier.applyHighlights() silently drops the update when the document modification stamp has changed between
collection and apply. Because OpenedDocument.updateDiagnostics() only calls scheduleRefresh when the diagnostic set actually changes, subsequent identical publishDiagnostics notifications are treated as unchanged and never re-applied, leaving stale squiggles in the editor.
Fix: on stamp mismatch, reschedule a new refresh via scheduleRefresh() instead of returning. The existing coalesceBy() ensures rapid reschedules during continuous typing are coalesced, not piled up. Once the user stops typing, the stamp matches and diagnostics apply normally.