[keithchong]

See GITOPS-11387 for details before reviewing

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: da0b22d8-7969-43f0-8482-234b5fd691c6

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 20.19704% with 324 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.15%. Comparing base (3bd1dab) to head (76313b0).
⚠️ Report is 68 commits behind head on main.

Files with missing lines	Patch %	Lines
...onents/overview/sync-activity/SyncActivityCard.tsx	0.00%	63 Missing ⚠️
...iew/operational-metrics/OperationalMetricsCard.tsx	0.00%	60 Missing ⚠️
...onents/overview/health-status/HealthStatusCard.tsx	0.00%	58 Missing ⚠️
src/gitops/components/overview/chartHelpers.tsx	65.13%	36 Missing and 2 partials ⚠️
...components/overview/sync-status/SyncStatusCard.tsx	0.00%	37 Missing ⚠️
...nts/overview/reconciliation/ReconciliationCard.tsx	0.00%	34 Missing ⚠️
...tops/components/overview/DashboardOverviewPage.tsx	0.00%	32 Missing ⚠️
src/gitops/utils/prometheusChartData.ts	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   11.30%   14.15%   +2.84%     
==========================================
  Files         169      192      +23     
  Lines        6679     7533     +854     
  Branches     2235     2506     +271     
==========================================
+ Hits          755     1066     +311     
- Misses       5923     6218     +295     
- Partials        1      249     +248     

Flag	Coverage Δ
unit-tests	14.15% <20.19%> (+2.84%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aali309]

Looks good to me in general just a few follow up/NIT comments. Also should we consider sharing one Application watch between Sync + Health cards?
Thanks @keithchong

[keithchong]

Looks good to me in general just a few follow up/NIT comments. Also should we consider sharing one Application watch between Sync + Health cards? Thanks @keithchong

Good point about sharing one app watch. For all the cards, it was supposed to be all self-contained and one can be inserted into another page independently. I agree, we could share that for both cards for now. In a separate commit, I pulled it up out of the two cards and into the DashboardOverviewPage and created a new interface OverviewCardForApplicationsProps for those cards with Apps dependencies.

[aali309]

one more comment @keithchong, Unknown is the Health filter id, so this link opens Health Status: Unknown and shows no apps!

[aali309]

Tested, LGTM! Thanks Keith