Run cheap guards before expensive analysis calls - #1062
Merged
Merged
Conversation
Reorder early-return guards in 7 Rector rules so cheap checks (isName/isNames/count/instanceof) bail out before costly type analysis (getType/isObjectType). Fixes new RectorCheaperGuardsFirstRule from symplify/phpstan-rules 14.13.0. Claude-Session: https://claude.ai/code/session_01Na4eYvNqa2pdhZrBXbegrv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
RectorCheaperGuardsFirstRulein symplify/phpstan-rules 14.13.0 flags a cheap early-return guard (isName(),isNames(),count(),instanceof, ...) that sits after an expensive analysis call (getType(),isObjectType(), ...) inside a Rector rule, when the cheap guard does not depend on the expensive call result.This reorders 7 such rules so non-matching nodes bail out before the costly type analysis runs. Behavior is unchanged; only guard order shifts.
Rules updated: