Show a live progress bar for each file-parsing step - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a rector-style live progress bar, like the one in TomasVotruba/reco, so long runs (e.g. mautic with vendor) show progress instead of hanging silently.
New
progress.go:renderProgressBar- Symfony-style bar (label done/total [===>---] NN%), redrawn in place with a carriage returnprogressEach- reads each file and drives the bar; skipped on a non-terminal run so piped output stays cleanBars go to stderr (step text stays on stdout) for four phases:
scanning,parsing(project + vendor),collecting,applying.