Repository navigation
chore(ci): stop demanding a bump from PRs that ship nothing - #27
Merged
Merged
Conversation
`files` is ["dist"], so a PR touching only docs, tests or workflows leaves the tarball byte-identical — and the check still failed until someone bumped. That is where 0.7.2 came from: a version whose only difference from 0.7.1 is the version string, which is why it was never published. The check now asks what the PR changes before asking for a version. Anything an installer receives — src, package.json, README, LICENSE — still requires the bump. Classification verified against real file lists: the 0.7.2 docs PR without its bump, a src change, a tests-only change, a README change, and the 0.7.1 workflow change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
package.jsonsays0.7.2. npm's latest is0.7.1. The difference between them is nothing an installer can observe.filesis["dist"], so the tarball is the build output plus the three files npm always adds —package.json,README.md,LICENSE. PRs #25 and #26 changedARCHITECTURE.md,CLAUDE.mdand two files underdocs/. None of that ships. But Version Check failed until the version moved, so it moved, and 0.7.2 became a release that cannot be worth publishing: its tarball differs from 0.7.1 only in the version string.I wrote the check that did this, in #21. The comment in it — "Every merge into main is released, so every PR must carry the bump" — is the premise that is wrong. Not every merge changes what is released.
What changed
One step ahead of the others: what did this PR touch?
If every changed file matches, the job says so and passes. If anything else changed —
src/,package.json,README.md,LICENSE— the three original steps run exactly as before. The comparison logic is untouched; it is only now preceded by a question.fetch-depth: 0is added because the diff needs the base commit.Verified
The classifier was run against real file lists rather than reasoned about:
ARCHITECTURE.md,CLAUDE.md,docs/*)package.json)README.md,bun.lock, workflows,package.json)src/core/scheduler.ts+ its testREADME.mdaloneThe second row is worth reading twice: a docs PR that does carry a bump still takes the strict path, and passes on its own merits. Only a PR with no publishable change at all skips.
What this does not do
It does not publish 0.7.2 and it does not revert the version.
package.jsonstays at0.7.2, unpublished, and the next change that actually ships goes out under that number. Tags, npm and GitHub Releases stay consistent — 0.7.2 simply has not happened yet, which is the normal state of an unreleased bump rather than the drift this repo has had before.🤖 Generated with Claude Code