Fix uncertain idempotency on transaction should retry without backoff - #127
Open
benh wants to merge 12 commits into
Open
Fix uncertain idempotency on transaction should retry without backoff#127benh wants to merge 12 commits into
benh wants to merge 12 commits into
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There is a race condition in database between the transaction lookup and the transaction creation, so if 2 threads running shared transactions will both pass the lookup and have no result, then they'll try to create and only one will win and second will crash the DB server with `CHECK(inserted)`.
onelxj
approved these changes
Aug 14, 2026
onelxj
reviewed
Aug 14, 2026
benh
force-pushed
the
fix-uncertain-idempotency-on-transaction-should-retry-without-backoff
branch
from
August 14, 2026 21:15
8140285 to
d7b2354
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
|
This pull request failed to merge: some required checks failed. After you have resolved the problem, you should remove the Failed checks: Build public repo for Linux x86_64 / GitHub-hosted Runner |
Don't treat `TransactionShouldRetryWithoutBackoff` as an uncertain mutation within an `IdempotencyManager` since it is not uncertain and it may cause the entire transaction to later abort due to that uncertainty rather than just letting `TransactionShouldRetryWithoutBackoff` propagate.
If a developer caught an error that is unrecoverable don't let them make more Reboot method calls which is just wasting resources since the whole transaction needs to abort anyway.
We need to correctly handle multiple calls to `IdempotencyManager.idempotently()` which may create uncertain mutations that we want to properly handle.
benh
force-pushed
the
fix-uncertain-idempotency-on-transaction-should-retry-without-backoff
branch
from
August 15, 2026 00:54
d7b2354 to
bfd65ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs reported from @mtrifiro.
See each commit.