fix: handle missing original_path during placeholder resolution - #561
Open
iamceeso wants to merge 1 commit into
Open
fix: handle missing original_path during placeholder resolution#561iamceeso wants to merge 1 commit into
iamceeso wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent AutoAPI from crashing when resolving placeholders with a missing or invalid
original_path.Currently
_resolve_module_placeholders()assumes every placeholder contains a valid stringoriginal_pathand unconditionally calls:In some projects, malformed or unresolved placeholders may contain
None, causing:This patch defensively validates
original_pathbefore use, logs a warning, removes the unresolved placeholder, and continues processing instead of aborting the build.Result
Validation