This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Use 'absolute' positioning for menu instead of 'fixed'#70
Open
cdevienne wants to merge 1 commit intoreactjs:masterfrom
Open
Use 'absolute' positioning for menu instead of 'fixed'#70cdevienne wants to merge 1 commit intoreactjs:masterfrom
cdevienne wants to merge 1 commit intoreactjs:masterfrom
Conversation
The 'fixed' referential may not be the document when a parent node has CSS transforms. But getBoundedClientRect() remains relative to the viewport no matter what. Calculating a fixed position from it is difficult. Using 'absolute' positioning makes things a lot easier. It is how bootstrap dropdown menu works for example.
cdevienne
force-pushed
the
menu-position-absolute
branch
from
208aaa2 to
04a394b
Compare
|
Also, on pages that have enough content to have a scroll, position: fixed fails horribly. |
|
@cdevienne There's no need for that maxWidth hack now, having position relative on the parent makes |
Collaborator
|
Just a heads-up (in case you're waiting for this PR to land): You can fully customize the dropdown menu by using We'll probably be removing most of the default menu styles for 2.0, possibly only keeping the absolute coordinates which are passed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'fixed' approach has a major downside:
The 'fixed' referential may not be the document when a parent node has CSS transforms.
But getBoundedClientRect() remains relative to the document no matter what.
Calculating a fixed position from it is difficult.
Using 'absolute' positioning makes things a lot easier. It is how bootstrap
dropdown menu works for example.