This repository was archived by the owner on Jul 19, 2019. It is now read-only.
[changed] isOpen function treats null or undefined prop as not being set#285
Open
acunniffe wants to merge 2 commits intoreactjs:masterfrom
Open
[changed] isOpen function treats null or undefined prop as not being set#285acunniffe wants to merge 2 commits intoreactjs:masterfrom
acunniffe wants to merge 2 commits intoreactjs:masterfrom
Conversation
added 2 commits
October 16, 2017 12:45
…set. some users may want to override isOpen and use the default behavior and logic. JSX does not support conditional setting of props so null is often treated as not set at all.
Collaborator
|
Hi Aidan! I agree, this change is probably sensible. The original thought was that Sadly, changing this logic as proposed would probably break a few implementations. It's very easy to pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users may want to use the isOpen override selectively depending on the app state. Right now even if you set it as undefined or null the code treats that as a definitive false.
Currently:
true is treated as true
false is treated as false
null is treated as false
undefined is treated as false
With this PR:
true is treated as true
false is treated as false
undefined is treated as [not set]
null is treated as [not set]