Repository navigation
Compile out RCTViewManager under RCT_REMOVE_LEGACY_COMPONENT_INTEROP - #59651
Open
christophpurrer wants to merge 1 commit into
Open
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary: Consumers who opt into `RCT_REMOVE_LEGACY_COMPONENT_INTEROP` now get the Paper `RCTViewManager` base class compiled out, along with its property macros and the supporting `RCTComponentData` implementation. Any remaining subclass fails at compile time instead of shipping unreachable code. The flag defaults to off, so default builds are unaffected. Changelog: [iOS][Added] - Compile out the Paper `RCTViewManager` base when `RCT_REMOVE_LEGACY_COMPONENT_INTEROP` is set Differential Revision: D128434146
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128434146. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Consumers who opt into
RCT_REMOVE_LEGACY_COMPONENT_INTEROPnow get the PaperRCTViewManagerbase class compiled out, along with its property macros and the supportingRCTComponentDataimplementation. Any remaining subclass fails at compile time instead of shipping unreachable code. The flag defaults to off, so default builds are unaffected.Changelog:
[iOS][Added] - Compile out the Paper
RCTViewManagerbase whenRCT_REMOVE_LEGACY_COMPONENT_INTEROPis setDifferential Revision: D128434146