Repository navigation
Cancel superseded Test All runs on pull requests - #59636
Open
cipolleschi wants to merge 1 commit into
Open
cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
Test All had no concurrency group, so every push to a pull request left the previous run going to completion. Over Oct 27-29 about 40% of the macOS minutes spent on iOS E2E went to runs whose pull request had already received a newer push. Cancel in-progress runs of the same pull request. Push and workflow_dispatch runs get a unique group and are never cancelled.
meta-cla
Bot
added
the
CLA Signed
This was referenced Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (iOS RNTester E2E cost, review bottom-up):
Summary:
Part 2 of the iOS E2E cost stack.
Test All has no
concurrencygroup, so a new push to a pull request leaves the previous run going until it finishes. Phabricator-exported branches get pushed repeatedly (one had 8 runs in a day). Over Oct 27–29, ~40% of the macOS minutes spent on the iOS RNTester E2E jobs went to runs whose pull request had already received a newer push. This overlaps with the retry minutes addressed in part 1.Cancel in-progress runs of the same pull request. Push and
workflow_dispatchruns each get a unique group (github.run_id), so runs onmainand*-stableare never cancelled.visual-compare-rntester.yml(triggered by Test All'sworkflow_run) already ignores cancelled runs.Changelog:
[INTERNAL] [CHANGED] - Cancel superseded Test All runs on pull requests
Test Plan:
actionlintreports no new issues.