Skip to content

Cover react/nativemodule/viewtransition with Stable API guards (#59058) #59058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
+4 −96
Closed

Cover react/nativemodule/viewtransition with Stable API guards (#59058) #59058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/nativemodule/viewtransition/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ target_include_directories(react_nativemodule_viewtransition PUBLIC ${REACT_COMM
target_link_libraries(react_nativemodule_viewtransition
react_codegen_rncore
react_cxxreact
react_cxxstableapi
react_renderer_bridging
react_renderer_core
react_renderer_uimanager
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/nativemodule/viewtransition/NativeViewTransition.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <optional>
#include <string>

Expand Down
1 change: 1 addition & 0 deletions ...ve/ReactCommon/react/nativemodule/viewtransition/React-viewtransitionnativemodule.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Pod::Spec.new do |s|
s.dependency "ReactCommon/turbomodule/core"
add_dependency(s, "React-Fabric")
s.dependency "React-Fabric/bridging"
s.dependency "React-cxxstableapi"
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
add_dependency(s, "React-RCTFBReactNativeSpec")

Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,14 +2077,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3126,14 +3126,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2076,14 +2076,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2076,14 +2076,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
}
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4330,14 +4330,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5308,14 +5308,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4321,14 +4321,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4329,14 +4329,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}

class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
}
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,14 +943,6 @@ class facebook::react::NativeMethodCallInvoker {
public virtual ~NativeMethodCallInvoker() = default;
}

class facebook::react::NativeViewTransition : public NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::Props : public virtual facebook::react::Sealable, public virtual facebook::react::DebugStringConvertible {
public Props() = default;
public Props(const facebook::react::Props& other) = default;
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1799,14 +1799,6 @@ class facebook::react::NativeModulePerfLogger {
public virtual ~NativeModulePerfLogger() = default;
}

class facebook::react::NativeViewTransition : public NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::ParagraphAttributes : public facebook::react::DebugStringConvertible {
public Float minimumFontScale;
public Float minimumFontSize;
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,14 +942,6 @@ class facebook::react::NativeMethodCallInvoker {
public virtual ~NativeMethodCallInvoker() = default;
}

class facebook::react::NativeViewTransition : public NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::Props : public virtual facebook::react::Sealable, public virtual facebook::react::DebugStringConvertible {
public Props() = default;
public Props(const facebook::react::Props& other) = default;
Expand Down
8 changes: 0 additions & 8 deletions scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,14 +942,6 @@ class facebook::react::NativeMethodCallInvoker {
public virtual ~NativeMethodCallInvoker() = default;
}

class facebook::react::NativeViewTransition : public NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
}

class facebook::react::Props : public virtual facebook::react::Sealable, public virtual facebook::react::DebugStringConvertible {
public Props() = default;
public Props(const facebook::react::Props& other) = default;
Expand Down
Loading