Skip to content

Make iOS Color default constructor constexpr #59044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 1 commit into from
+7 −5
Closed

Make iOS Color default constructor constexpr #59044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ctCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/HostPlatformColor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ struct Color {
Color(int32_t color);
Color(const DynamicColor &dynamicColor);
Color(const ColorComponents &components);
Color() : uiColor_(nullptr) {};
// constexpr so `UndefinedColor` below is constant-initialized instead of
// emitting a static initializer in every translation unit that includes it.
constexpr Color() : uiColor_(nullptr), uiColorHashValue_(0) {};
int32_t getColor() const;
std::size_t getUIColorHash() const;

Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5325,7 +5325,7 @@ struct facebook::react::Bridging<void> {
}

struct facebook::react::Color {
public Color();
public constexpr Color();
public Color(const facebook::react::ColorComponents& components);
public Color(const facebook::react::DynamicColor& dynamicColor);
public Color(int32_t color);
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8150,7 +8150,7 @@ struct facebook::react::CallbackWithId {
}

struct facebook::react::Color {
public Color();
public constexpr Color();
public Color(const facebook::react::ColorComponents& components);
public Color(const facebook::react::DynamicColor& dynamicColor);
public Color(int32_t color);
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5310,7 +5310,7 @@ struct facebook::react::Bridging<void> {
}

struct facebook::react::Color {
public Color();
public constexpr Color();
public Color(const facebook::react::ColorComponents& components);
public Color(const facebook::react::DynamicColor& dynamicColor);
public Color(int32_t color);
Expand Down
2 changes: 1 addition & 1 deletion scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5318,7 +5318,7 @@ struct facebook::react::Bridging<void> {
}

struct facebook::react::Color {
public Color();
public constexpr Color();
public Color(const facebook::react::ColorComponents& components);
public Color(const facebook::react::DynamicColor& dynamicColor);
public Color(int32_t color);
Expand Down
Loading