Skip to content

chore(ios): mark -[RCTSurfacePresenter addObserver:] as deprecated #59011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tjzel wants to merge 1 commit into from
Closed

chore(ios): mark -[RCTSurfacePresenter addObserver:] as deprecated #59011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-native/React/Fabric/RCTSurfacePresenter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ NS_ASSUME_NONNULL_BEGIN
* Deprecated.
* Use `RCTMountingTransactionObserverCoordinator` instead.
*/
- (void)addObserver:(id<RCTSurfacePresenterObserver>)observer;
- (void)addObserver:(id<RCTSurfacePresenterObserver>)observer
__deprecated_msg("Use RCTMountingTransactionObserverCoordinator instead.");
- (void)removeObserver:(id<RCTSurfacePresenterObserver>)observer;

/*
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native/React/Fabric/RCTSurfacePresenter.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,11 +429,14 @@ - (void)schedulerDidSetIsJSResponder:(BOOL)isJSResponder
[_mountingManager setIsJSResponder:isJSResponder blockNativeResponder:blockNativeResponder forShadowView:shadowView];
}

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-implementations"
- (void)addObserver:(id<RCTSurfacePresenterObserver>)observer
{
std::unique_lock lock(_observerListMutex);
_observers.push_back(observer);
}
#pragma clang diagnostic pop

- (void)removeObserver:(id<RCTSurfacePresenterObserver>)observer
{
Expand Down
Loading