Skip to content

feat(media): add source-bound video posters and pixel checks - #59001

Closed
iray-tno wants to merge 2 commits into
react:mainfrom
iray-tno:iray-tno/android-line-break-config
Closed

iray-tno wants to merge 2 commits into
react:mainfrom
iray-tno:iray-tno/android-line-break-config

Conversation

@iray-tno

Copy link
Copy Markdown
Contributor

Summary:

Changelog:

Test Plan:

iray-tno and others added 2 commits October 9, 2026 13:39
Android 13 (API 33) added LineBreakConfig, which selects the
strictness of the line-breaking rules (CSS `line-break`: loose,
normal, strict) and phrase-based breaking for Japanese (CSS
`word-break: auto-phrase`). React Native measures and draws Text with
a StaticLayout it builds itself, so neither setting can be reached from
outside: a native module could only change the drawn TextView, which
would then disagree with the height Yoga measured.

Add two Android-only paragraph props, plumbed the same way as
android_hyphenationFrequency:

- android_lineBreakStyle: 'none' | 'loose' | 'normal' | 'strict'
- android_lineBreakWordStyle: 'none' | 'phrase'

They go into ParagraphAttributes and the paragraph MapBuffer, are
applied to the StaticLayout.Builder in TextLayoutManager (measurement
and the prepared layout), and to ReactTextView through @ReactProp
setters (drawing). Both are ignored below API 33. When both are
'none' (the default) no LineBreakConfig is set, so existing text lays
out exactly as before.

TextInput is left out: it does not list the props in its view config.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regenerate the Frameworks C++ API snapshots (Common, Android, Apple)
for the new LineBreakStyle and LineBreakWordStyle enums, their
conversions, the ParagraphAttributes fields and the paragraph
MapBuffer keys. Generated with `yarn cxx-api-build` using Doxygen
1.16.1, the version the validation workflow pins.

Document that android_lineBreakWordStyle="phrase" depends on the
locale: Android Text is laid out in the device locale, and where that
locale has no phrase-based breaking the setting has no effect.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 12, 2026
@iray-tno iray-tno closed this Oct 12, 2026
@github-actions

Copy link
Copy Markdown

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING

@github-actions

Copy link
Copy Markdown

Caution

Invalid Changelog Format

Please verify your Changelog format. See Changelog format

@iray-tno

Copy link
Copy Markdown
Contributor Author

sorry mistook, dup with 59002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant