Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #58990.
When a hardware Enter key is pressed in a
multilineTextInput withsubmitBehavior="submit",TextViewcalls the editor action listener on key down, and because the listener returnstrueit setsenterDownand calls the listener again on key up with the sameIME_NULLaction. Our listener doesn't look at the key event, so it dispatchesonSubmitEditingboth times. Single-line inputs don't hit this becauseReactEditText.onKeyUpalready consumes Enter beforeTextViewsees it, and IME action buttons pass a null event.The listener now ignores the key-up call and just keeps consuming it.
TextViewonly calls the listener on key up after the key down was already handled, so nothing else changes.Changelog:
[ANDROID] [FIXED] - Fix
onSubmitEditingfiring twice when pressing a hardware Enter key in a multiline TextInput withsubmitBehavior="submit"Test Plan:
Added
ReactTextInputSubmitEditingTest, which sends an Enter key down and key up to a multiline TextInput withsubmitBehavior="submit"and checks that only one submit event is dispatched. It fails onmain(2 dispatches) and passes with this change.ReactTextInputPropertyTest(28) and the new test pass.