Repository navigation
Coordinate inspector and transport shutdown - #58996
Closed
Abbondanzo wants to merge 2 commits into
Closed
Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
Summary: Dispatch tasks through uniquely owned callable payloads so queue bookkeeping never copies or destroys populated captures while holding its mutex. Cancel queued work outside the queue lock, distinguish worker-thread shutdown requests from external-owner joining, and wake timed waits when the queue head changes. Add focused dispatcher admission, cancellation, callable-copy, reentrant destruction and joining regressions. Inspector ownership and tester readiness are separate dependent increments, not behavior introduced here. Changelog: [General][Fixed] - Fix native dispatcher callback ownership and shutdown synchronization Differential Revision: D124671180
Summary: Retain the inspector until serialized target and socket cleanup has completed, reject late work during shutdown, and join the dispatcher from its external owner. Keep transport close requests callable from IO callbacks without self-joining or holding the socket lock across a join. Serialize writes and pings on the IO executor, discard expired implementation references, and make external-owner destruction finish cleanup when a closed callback throws. Add focused inspector lifetime and real loopback transport regressions, including active-IO destruction, nested close, late connection completions, and invalid descriptors. Destruction of a socket wrapper on its own IO thread remains unsupported. Changelog: [General][Fixed] - Fix native inspector ownership and transport shutdown races Differential Revision: D124675718
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124675718. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Retain the inspector until serialized target and socket cleanup has completed, reject late work during shutdown, and join the dispatcher from its external owner. Keep transport close requests callable from IO callbacks without self-joining or holding the socket lock across a join. Serialize writes and pings on the IO executor, discard expired implementation references, and make external-owner destruction finish cleanup when a closed callback throws.
Add focused inspector lifetime and real loopback transport regressions, including active-IO destruction, nested close, late connection completions, and invalid descriptors. Destruction of a socket wrapper on its own IO thread remains unsupported.
Changelog:
[General][Fixed] - Fix native inspector ownership and transport shutdown races
Differential Revision: D124675718