fix: stale VoiceOver value from async UI updates to Text - #58169
Open
coolsoftwaretyler wants to merge 1 commit into
Open
fix: stale VoiceOver value from async UI updates to Text#58169coolsoftwaretyler wants to merge 1 commit into
coolsoftwaretyler wants to merge 1 commit into
Conversation
|
@christophpurrer has imported this pull request. If you are a Meta employee, you can view this in D117875865. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a targeted fix for #58145, where I observed iOS VoiceOver reading stale values over
Textelements that were updated asynchronously (from asetTimeoutcall).This patch definitely fixes the issue, but I'm happy to iterate on the design if there are any considerations I haven't taken into account: coolsoftwaretyler/focusissues#1
Maybe related to #49462? Although what I found is that when VoiceOver encountered a failure, it bounced back to the status bar, so it's possible 49462 is some other issue with modals that presents the same failure mode.
Changelog:
Pick one each for the category and type tags:
[IOS] [FIXED] -VoiceOver text readout when changing elements asynchronously
Test Plan:
I built a reproducer and tested this patch with it. To test:
Before
641000653-9506a48b-7ac4-4728-8908-1148aeb7ad07.mp4
After
ScreenRecording_08-27-2026.10-36-35_1.MP4