Delete TextAncestor compatibility shim#57177
Open
yaminyassin wants to merge 1 commit into
Open
Conversation
The shim file `packages/react-native/Libraries/Text/TextAncestor.js` was kept solely to support react-strict-dom's deep import. The file's own comment carried a TODO from @huntie to delete it once the cross-repo reference was fixed. react-strict-dom has now switched to the public `unstable_TextAncestorContext` API (react/react-strict-dom#477), exposed in react#52368. No internal React Native consumers reference this shim — both `packages/react-native/index.js` and `index.js.flow` import `./Libraries/Text/TextAncestorContext` directly. ## Changelog: [INTERNAL] - Delete TextAncestor compatibility shim
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the replacement for #56813. GitHub could not reopen the original PR because I had to delete and recreate my fork.
This deletes
packages/react-native/Libraries/Text/TextAncestor.js, a compatibility shim for the oldreact-strict-domdeep import.react-strict-domnow uses the publicunstable_TextAncestorContextAPI instead.Changelog:
[Internal] [Removed] - Remove the
Libraries/Text/TextAncestorcompatibility shim afterreact-strict-dommoved tounstable_TextAncestorContextTest Plan
Validated locally on
chore/delete-text-ancestor-shim.All checks passed. Jest passed with 275 test suites, 5635 tests, 1 skipped, and 1798 snapshots.