Make the HelloWorld dynamic-frameworks CI lane actually use dynamic frameworks (#58962)

Summary:
#54482 changed the `test_ios_helloworld` matrix from `use_frameworks: [StaticLibraries, DynamicFrameworks]` to `[false, true]` and updated `test-ios-rntester` to match, but `test-ios-helloworld` still checks the input against `"DynamicFrameworks"`:

```bash
if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
  args+=(--frameworks dynamic)
fi
```

So the `true` lane builds with static libraries, the same as the `false` lane, and HelloWorld with dynamic frameworks is no longer tested. The Debug exclude (`use_frameworks: StaticLibraries`) also matches nothing, so `(Debug, false)` runs even though the Ruby 3.2.0 job already covers it. The latest Test All run on main shows all four `test_ios_helloworld` combinations.

This makes the action compare the input to `"true"`, as `test-ios-rntester` does, and changes the exclude to `use_frameworks: false`. The Ruby 3.2.0 job passes no `use-frameworks`, so it keeps the default and still builds static libraries.

## Changelog:

[INTERNAL] [FIXED] - Make the HelloWorld dynamic-frameworks CI lane use dynamic frameworks

Pull Request resolved: #58962

Test Plan:
- `actionlint` on `test-all.yml`: the "value StaticLibraries in exclude does not match" error is gone.
- On this PR, Test All should run three `test_ios_helloworld` jobs, and the `(…, true)` ones should pass `--frameworks dynamic` to `yarn bootstrap ios`.

Reviewed By: christophpurrer

Differential Revision: D124991517

Pulled By: cipolleschi

fbshipit-source-id: 0fc93840150ef014feee2499183cb1f1605d0bbf

Author: xThreeh

.github/actions/test-ios-helloworld/action.yml

@@ -2,8 +2,8 @@ name: test-ios-helloworld
 description: Test iOS Hello World
 inputs:
   use-frameworks:
-    description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
-    default: StaticLibraries
+    description: Whether to build with dynamic frameworks.
+    default: false
   ruby-version:
     description: The version of ruby that must be used
     default: 2.6.10
@@ -51,7 +51,7 @@ runs:
         cd private/helloworld
         args=()
 
-        if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
+        if [[ "${{ inputs.use-frameworks }}" == "true" ]]; then
           args+=(--frameworks dynamic)
         fi
 

.github/workflows/test-all.yml

@@ -534,7 +534,7 @@ jobs:
         exclude:
           # This config is tested with Ruby 3.2.0. Let's not double test it.
           - flavor: Debug
-            use_frameworks: StaticLibraries
+            use_frameworks: false
     env:
       PROJECT_NAME: iOSTemplateProject
       YARN_ENABLE_IMMUTABLE_INSTALLS: false