Skip to content

Commit dcc38df

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Mark RCTLegacyViewManagerInteropCoordinator.h as private (#59070)
Summary: Pull Request resolved: #59070 Mark `RCTLegacyViewManagerInteropCoordinator.h` as private, the last unguarded header in `legacyviewmanagerinterop`. Its only includer, `RCTLegacyViewManagerInteropCoordinatorAdapter.h`, is an exported header, so it now forward-declares the coordinator instead of importing it. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D125207358 fbshipit-source-id: 619cb14161b5a36d31ac2817024a441da95605fc
1 parent ca8504b commit dcc38df

8 files changed

Lines changed: 9 additions & 41 deletions

File tree

‎packages/react-native/React/Fabric/Mounting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropComponentView.mm‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
#import <React/UIView+React.h>
1616
#import <react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropComponentDescriptor.h>
1717
#import <react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropViewProps.h>
18+
#import <react/renderer/components/legacyviewmanagerinterop/RCTLegacyViewManagerInteropCoordinator.h>
1819
#import <react/utils/ManagedObjectWrapper.h>
1920
#import "RCTLegacyViewManagerInteropCoordinatorAdapter.h"
2021

‎packages/react-native/React/Fabric/Mounting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropCoordinatorAdapter.h‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,14 @@
88
#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP
99

1010
#import <Foundation/Foundation.h>
11-
#import <react/renderer/components/legacyviewmanagerinterop/RCTLegacyViewManagerInteropCoordinator.h>
11+
#import <UIKit/UIKit.h>
12+
#include <folly/dynamic.h>
13+
#include <string>
1214

1315
NS_ASSUME_NONNULL_BEGIN
1416

17+
@class RCTLegacyViewManagerInteropCoordinator;
18+
1519
@interface RCTLegacyViewManagerInteropCoordinatorAdapter : NSObject
1620

1721
- (instancetype)initWithCoordinator:(RCTLegacyViewManagerInteropCoordinator *)coordinator reactTag:(NSInteger)tag;

‎packages/react-native/React/Fabric/Mounting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropCoordinatorAdapter.mm‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP
1111

1212
#import <React/UIView+React.h>
13+
#import <react/renderer/components/legacyviewmanagerinterop/RCTLegacyViewManagerInteropCoordinator.h>
1314
#import <react/utils/FollyConvert.h>
1415

1516
@implementation RCTLegacyViewManagerInteropCoordinatorAdapter {

‎packages/react-native/ReactCommon/react/renderer/components/legacyviewmanagerinterop/platform/ios/react/renderer/components/legacyviewmanagerinterop/RCTLegacyViewManagerInteropCoordinator.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#include <react/cxxstableapi/PrivateGuard.h>
9+
810
#ifndef RCT_REMOVE_LEGACY_COMPONENT_INTEROP
911

1012
#import <Foundation/Foundation.h>

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,16 +1292,6 @@ interface RCTLegacyViewManagerInteropComponentView : public RCTViewComponentView
12921292
public virtual static void supportLegacyViewManagersWithPrefix:(NSString* prefix);
12931293
}
12941294

1295-
interface RCTLegacyViewManagerInteropCoordinator : public NSObject {
1296-
public virtual NSString* componentViewName();
1297-
public virtual UIView* createPaperViewWithTag:(NSInteger tag);
1298-
public virtual instancetype initWithComponentData:bridge:bridgeProxy:bridgelessInteropData:(RCTComponentData* componentData, _Nullable RCTBridge* bridge, _Nullable RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgelessInteropData);
1299-
public virtual void addObserveForTag:usingBlock:(NSInteger tag, InterceptorBlock block);
1300-
public virtual void handleCommand:args:reactTag:paperView:(NSString* commandName, NSArray* args, NSInteger tag, UIView* paperView);
1301-
public virtual void removeObserveForTag:(NSInteger tag);
1302-
public virtual void setProps:forView:(NSDictionary<NSString*, id>* props, UIView* view);
1303-
}
1304-
13051295
interface RCTLegacyViewManagerInteropCoordinatorAdapter : public NSObject {
13061296
public @property (copy) void(^eventInterceptor)(std::string eventName, folly::dynamic&& event);
13071297
public @property (strong) UIView* paperView;

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,16 +1335,6 @@ interface RCTLegacyViewManagerInteropComponentView : public RCTViewComponentView
13351335
public virtual static void supportLegacyViewManagersWithPrefix:(NSString* prefix);
13361336
}
13371337

1338-
interface RCTLegacyViewManagerInteropCoordinator : public NSObject {
1339-
public virtual NSString* componentViewName();
1340-
public virtual UIView* createPaperViewWithTag:(NSInteger tag);
1341-
public virtual instancetype initWithComponentData:bridge:bridgeProxy:bridgelessInteropData:(RCTComponentData* componentData, _Nullable RCTBridge* bridge, _Nullable RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgelessInteropData);
1342-
public virtual void addObserveForTag:usingBlock:(NSInteger tag, InterceptorBlock block);
1343-
public virtual void handleCommand:args:reactTag:paperView:(NSString* commandName, NSArray* args, NSInteger tag, UIView* paperView);
1344-
public virtual void removeObserveForTag:(NSInteger tag);
1345-
public virtual void setProps:forView:(NSDictionary<NSString*, id>* props, UIView* view);
1346-
}
1347-
13481338
interface RCTLegacyViewManagerInteropCoordinatorAdapter : public NSObject {
13491339
public @property (copy) void(^eventInterceptor)(std::string eventName, folly::dynamic&& event);
13501340
public @property (strong) UIView* paperView;

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,16 +1292,6 @@ interface RCTLegacyViewManagerInteropComponentView : public RCTViewComponentView
12921292
public virtual static void supportLegacyViewManagersWithPrefix:(NSString* prefix);
12931293
}
12941294

1295-
interface RCTLegacyViewManagerInteropCoordinator : public NSObject {
1296-
public virtual NSString* componentViewName();
1297-
public virtual UIView* createPaperViewWithTag:(NSInteger tag);
1298-
public virtual instancetype initWithComponentData:bridge:bridgeProxy:bridgelessInteropData:(RCTComponentData* componentData, _Nullable RCTBridge* bridge, _Nullable RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgelessInteropData);
1299-
public virtual void addObserveForTag:usingBlock:(NSInteger tag, InterceptorBlock block);
1300-
public virtual void handleCommand:args:reactTag:paperView:(NSString* commandName, NSArray* args, NSInteger tag, UIView* paperView);
1301-
public virtual void removeObserveForTag:(NSInteger tag);
1302-
public virtual void setProps:forView:(NSDictionary<NSString*, id>* props, UIView* view);
1303-
}
1304-
13051295
interface RCTLegacyViewManagerInteropCoordinatorAdapter : public NSObject {
13061296
public @property (copy) void(^eventInterceptor)(std::string eventName, folly::dynamic&& event);
13071297
public @property (strong) UIView* paperView;

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,16 +1292,6 @@ interface RCTLegacyViewManagerInteropComponentView : public RCTViewComponentView
12921292
public virtual static void supportLegacyViewManagersWithPrefix:(NSString* prefix);
12931293
}
12941294

1295-
interface RCTLegacyViewManagerInteropCoordinator : public NSObject {
1296-
public virtual NSString* componentViewName();
1297-
public virtual UIView* createPaperViewWithTag:(NSInteger tag);
1298-
public virtual instancetype initWithComponentData:bridge:bridgeProxy:bridgelessInteropData:(RCTComponentData* componentData, _Nullable RCTBridge* bridge, _Nullable RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgelessInteropData);
1299-
public virtual void addObserveForTag:usingBlock:(NSInteger tag, InterceptorBlock block);
1300-
public virtual void handleCommand:args:reactTag:paperView:(NSString* commandName, NSArray* args, NSInteger tag, UIView* paperView);
1301-
public virtual void removeObserveForTag:(NSInteger tag);
1302-
public virtual void setProps:forView:(NSDictionary<NSString*, id>* props, UIView* view);
1303-
}
1304-
13051295
interface RCTLegacyViewManagerInteropCoordinatorAdapter : public NSObject {
13061296
public @property (copy) void(^eventInterceptor)(std::string eventName, folly::dynamic&& event);
13071297
public @property (strong) UIView* paperView;

0 commit comments

Comments
 (0)