Skip to content

Commit 96a89f9

Browse files
coadometa-codesync[bot]
authored andcommitted
Classify RCTTurboModuleManager.h as for-frameworks (#58948)
Summary: Pull Request resolved: #58948 Add the for-frameworks guard to the iOS `RCTTurboModuleManager.h`. `RCTTurboModuleManager` creates and owns TurboModules for a host, and `RCTTurboModuleManagerDelegate` is the protocol a host implements to supply them. That is host-integration API, in the same tier as `RCTHost.h` and `RCTInstance.h`, which are already for-frameworks: the app factory delegate in `RCTReactNativeFactory.h` adopts both `RCTHostDelegate` and `RCTTurboModuleManagerDelegate`, and imports both headers. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D124079995 fbshipit-source-id: 9b25b84d9eb1a9913630ca4a463db644ddc009ac
1 parent 277e57e commit 96a89f9

4 files changed

Lines changed: 2 additions & 42 deletions

File tree

‎packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#import <memory>
1113

1214
#import <React/NativeModuleCore.h>

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1929,12 +1929,6 @@ interface RCTTransformAnimatedNode : public RCTAnimatedNode {
19291929
public virtual NSDictionary<NSString*, NSObject*>* propsDictionary();
19301930
}
19311931

1932-
interface RCTTurboModuleManager : public NSObject <RCTTurboModuleRegistry> {
1933-
public virtual instancetype initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:(RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgeModuleDecorator, id<RCTTurboModuleManagerDelegate> delegate, std::shared_ptr<facebook::react::CallInvoker> jsInvoker, RCTDevMenuConfigurationDecorator* devMenuConfigurationDecorator);
1934-
public virtual void installJSBindings:(facebook::jsi::Runtime& runtime);
1935-
public virtual void invalidate();
1936-
}
1937-
19381932
interface RCTUIImageViewAnimated : public UIImageView {
19391933
}
19401934

@@ -2953,14 +2947,6 @@ protocol RCTTurboModule : public RCTModuleProvider {
29532947
public virtual void setEventEmitterCallback:(EventEmitterCallbackWrapper* eventEmitterCallbackWrapper);
29542948
}
29552949

2956-
protocol RCTTurboModuleManagerDelegate : public NSObject {
2957-
public virtual Class getModuleClassFromName:(const char* name);
2958-
public virtual NSArray<id<RCTBridgeModule>>* extraModulesForBridge:((deprecated("Please make all native modules returned from this method TurboModule-compatible.")) __attribute);
2959-
public virtual id<RCTModuleProvider> getModuleProvider:(const char* name);
2960-
public virtual id<RCTTurboModule> getModuleInstanceFromClass:(Class moduleClass);
2961-
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:jsInvoker:(const std::string& name, std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2962-
}
2963-
29642950
protocol RCTTurboModuleRegistry : public NSObject {
29652951
public virtual BOOL moduleIsInitialized:(const char* moduleName);
29662952
public virtual id moduleForName:(const char* moduleName);

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1922,12 +1922,6 @@ interface RCTTransformAnimatedNode : public RCTAnimatedNode {
19221922
public virtual NSDictionary<NSString*, NSObject*>* propsDictionary();
19231923
}
19241924

1925-
interface RCTTurboModuleManager : public NSObject <RCTTurboModuleRegistry> {
1926-
public virtual instancetype initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:(RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgeModuleDecorator, id<RCTTurboModuleManagerDelegate> delegate, std::shared_ptr<facebook::react::CallInvoker> jsInvoker, RCTDevMenuConfigurationDecorator* devMenuConfigurationDecorator);
1927-
public virtual void installJSBindings:(facebook::jsi::Runtime& runtime);
1928-
public virtual void invalidate();
1929-
}
1930-
19311925
interface RCTUIImageViewAnimated : public UIImageView {
19321926
}
19331927

@@ -2945,14 +2939,6 @@ protocol RCTTurboModule : public RCTModuleProvider {
29452939
public virtual void setEventEmitterCallback:(EventEmitterCallbackWrapper* eventEmitterCallbackWrapper);
29462940
}
29472941

2948-
protocol RCTTurboModuleManagerDelegate : public NSObject {
2949-
public virtual Class getModuleClassFromName:(const char* name);
2950-
public virtual NSArray<id<RCTBridgeModule>>* extraModulesForBridge:((deprecated("Please make all native modules returned from this method TurboModule-compatible.")) __attribute);
2951-
public virtual id<RCTModuleProvider> getModuleProvider:(const char* name);
2952-
public virtual id<RCTTurboModule> getModuleInstanceFromClass:(Class moduleClass);
2953-
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:jsInvoker:(const std::string& name, std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2954-
}
2955-
29562942
protocol RCTTurboModuleRegistry : public NSObject {
29572943
public virtual BOOL moduleIsInitialized:(const char* moduleName);
29582944
public virtual id moduleForName:(const char* moduleName);

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1929,12 +1929,6 @@ interface RCTTransformAnimatedNode : public RCTAnimatedNode {
19291929
public virtual NSDictionary<NSString*, NSObject*>* propsDictionary();
19301930
}
19311931

1932-
interface RCTTurboModuleManager : public NSObject <RCTTurboModuleRegistry> {
1933-
public virtual instancetype initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:(RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgeModuleDecorator, id<RCTTurboModuleManagerDelegate> delegate, std::shared_ptr<facebook::react::CallInvoker> jsInvoker, RCTDevMenuConfigurationDecorator* devMenuConfigurationDecorator);
1934-
public virtual void installJSBindings:(facebook::jsi::Runtime& runtime);
1935-
public virtual void invalidate();
1936-
}
1937-
19381932
interface RCTUIImageViewAnimated : public UIImageView {
19391933
}
19401934

@@ -2953,14 +2947,6 @@ protocol RCTTurboModule : public RCTModuleProvider {
29532947
public virtual void setEventEmitterCallback:(EventEmitterCallbackWrapper* eventEmitterCallbackWrapper);
29542948
}
29552949

2956-
protocol RCTTurboModuleManagerDelegate : public NSObject {
2957-
public virtual Class getModuleClassFromName:(const char* name);
2958-
public virtual NSArray<id<RCTBridgeModule>>* extraModulesForBridge:((deprecated("Please make all native modules returned from this method TurboModule-compatible.")) __attribute);
2959-
public virtual id<RCTModuleProvider> getModuleProvider:(const char* name);
2960-
public virtual id<RCTTurboModule> getModuleInstanceFromClass:(Class moduleClass);
2961-
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:jsInvoker:(const std::string& name, std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2962-
}
2963-
29642950
protocol RCTTurboModuleRegistry : public NSObject {
29652951
public virtual BOOL moduleIsInitialized:(const char* moduleName);
29662952
public virtual id moduleForName:(const char* moduleName);

0 commit comments

Comments
 (0)