Repository navigation
Conversation
Contributor
|
@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125674123. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 19, 2026
Summary: Audits every page under `docs/` against the current source and fixes statements that are wrong or out of date, and documents current options and APIs that were missing. This change only corrects content; readability changes follow separately. **Configuration** - Config file lookup order: `.json` is tried before TypeScript files. - `maxWorkers`: configured values are not capped at the core count; the default is 50-75% of cores, not "about half". - `unstable_perfLoggerFactory`: event type is `'START_UP'` (not `'STARTUP'`), `opts` is optional and `key` is a number. - `hasteImplModulePath` modules must also export `getCacheKey()`. - `dynamicDepsInPackages` only applies to files in `node_modules`; dynamic requires elsewhere are always rejected. - Fixed defaults/types of `getPolyfills` (`[]`), `processModuleFilter` (one module), `getRunModuleStatement`, `schemeResolvers` (not nullable), `enhanceMiddleware`, `getTransformOptions` (`hot: true`). - Fixed descriptions of `assetRegistryPath`, `enableBabelRuntime` (plugin name), `rewriteRequestUrl` (order relative to middleware), `useGlobalHotkey` (has no effect), `blockList` (default hides `__tests__`), `mergeConfig` (one level deep; first argument can't be a promise), `tls`/`secureServerOptions` precedence. - Documented missing options: the `symbolicator` section, `resolver.dependencyExtractor`, `transformer.globalPrefix`/`allowOptionalDependencies`/`publicPath`, `serializer.polyfillModuleNames`/`customSerializer`/`experimentalSerializerHook` and extra `getTransformOptions` fields. `unstable_*` options not documented before follow in the next change. **API, CLI, Getting Started** - `runServer` and `createConnectMiddleware` have no `port` option; `runBuild`'s `out` is optional; corrected how source maps are written and inlined. - `runServer` calls `runMetro`, not the other way around; fixed an example using an undefined `httpServer`. - `dev` sets `__DEV__`; production builds inline `process.env.NODE_ENV` as `'production'`. - Documented missing options of `loadConfig`, `runMetro`, `runBuild` (including `output`), `runServer`, `createConnectMiddleware`, and the `buildGraph` and `attachMetroCli` exports. - CLI: documented `serve` options and the `start` alias, deprecated and ignored flags, `get-dependencies [entryFile]` and corrected defaults; every `--max-workers` overrides `maxWorkers`. - Documented all bundle URL query parameters and the transformer `transform`/`getCacheKey(options)` interface. **Resolution and Package Exports** - `#` subpath imports are supported (the docs said they throw). - Corrected the Haste, directory, `"browser"` field and file variant resolution steps, the `unstable_conditionsByPlatform` field name, asset variant naming (`2x`), `getPackage`/`getPackageForModule`/`asyncType` types, resolver caching conditions, and documented missing context fields. - Fixed the invalid custom resolver example and outdated warning text in Package Exports, and converted absolute links to relative ones. **Other pages** - Bundling: corrected the indexed RAM bundle header, offsets, lookup formulas and `UNBUNDLE` location; explained startup code and other unexplained terms. - Caching: `HttpCache` doesn't exist; documented `HttpStore` options, `HttpGetStore` error handling and `AutoCleanFileStore(options)`. - Module API, Source Map Format and Local Development: corrected `dynamicDepsInPackages` scope, the mappings grammar and the project scaffolding command. Also adds a doc comment to `getMaxWorkers`. Changelog: [Internal] Differential Revision: D125674123
meta-codesync
Bot
force-pushed
the
export-D125674123
branch
from
October 19, 2026 12:24
3d6ecb7 to
f5acdd7
Compare
Summary: Pull Request resolved: #2077 Audits every page under `docs/` against the current source and fixes statements that are wrong or out of date, and documents current options and APIs that were missing. This change only corrects content; readability changes follow separately. **Configuration** - Config file lookup order: `.json` is tried before TypeScript files. - `maxWorkers`: configured values are not capped at the core count; the default is 50-75% of cores, not "about half". - `unstable_perfLoggerFactory`: event type is `'START_UP'` (not `'STARTUP'`), `opts` is optional and `key` is a number. - `hasteImplModulePath` modules must also export `getCacheKey()`. - `dynamicDepsInPackages` only applies to files in `node_modules`; dynamic requires elsewhere are always rejected. - Fixed defaults/types of `getPolyfills` (`[]`), `processModuleFilter` (one module), `getRunModuleStatement`, `schemeResolvers` (not nullable), `enhanceMiddleware`, `getTransformOptions` (`hot: true`). - Fixed descriptions of `assetRegistryPath`, `enableBabelRuntime` (plugin name), `rewriteRequestUrl` (order relative to middleware), `useGlobalHotkey` (has no effect), `blockList` (default hides `__tests__`), `mergeConfig` (one level deep; first argument can't be a promise), `tls`/`secureServerOptions` precedence. - Documented missing options: the `symbolicator` section, `resolver.dependencyExtractor`, `transformer.globalPrefix`/`allowOptionalDependencies`/`publicPath`, `serializer.polyfillModuleNames`/`customSerializer`/`experimentalSerializerHook` and extra `getTransformOptions` fields. `unstable_*` options not documented before follow in the next change. **API, CLI, Getting Started** - `runServer` and `createConnectMiddleware` have no `port` option; `runBuild`'s `out` is optional; corrected how source maps are written and inlined. - `runServer` calls `runMetro`, not the other way around; fixed an example using an undefined `httpServer`. - `dev` sets `__DEV__`; production builds inline `process.env.NODE_ENV` as `'production'`. - Documented missing options of `loadConfig`, `runMetro`, `runBuild` (including `output`), `runServer`, `createConnectMiddleware`, and the `buildGraph` and `attachMetroCli` exports. - CLI: documented `serve` options and the `start` alias, deprecated and ignored flags, `get-dependencies [entryFile]` and corrected defaults; every `--max-workers` overrides `maxWorkers`. - Documented all bundle URL query parameters and the transformer `transform`/`getCacheKey(options)` interface. **Resolution and Package Exports** - `#` subpath imports are supported (the docs said they throw). - Corrected the Haste, directory, `"browser"` field and file variant resolution steps, the `unstable_conditionsByPlatform` field name, asset variant naming (`2x`), `getPackage`/`getPackageForModule`/`asyncType` types, resolver caching conditions, and documented missing context fields. - Fixed the invalid custom resolver example and outdated warning text in Package Exports, and converted absolute links to relative ones. **Other pages** - Bundling: corrected the indexed RAM bundle header, offsets, lookup formulas and `UNBUNDLE` location; explained startup code and other unexplained terms. - Caching: `HttpCache` doesn't exist; documented `HttpStore` options, `HttpGetStore` error handling and `AutoCleanFileStore(options)`. - Module API, Source Map Format and Local Development: corrected `dynamicDepsInPackages` scope, the mappings grammar and the project scaffolding command. Also adds a doc comment to `getMaxWorkers`. Changelog: [Internal] Differential Revision: D125674123
meta-codesync
Bot
force-pushed
the
export-D125674123
branch
from
October 19, 2026 12:26
f5acdd7 to
c5a2780
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Audits every page under
docs/against the current source and fixes statements that are wrong or out of date, and documents current options and APIs that were missing. This change only corrects content; readability changes follow separately.Configuration
.jsonis tried before TypeScript files.maxWorkers: configured values are not capped at the core count; the default is 50-75% of cores, not "about half".unstable_perfLoggerFactory: event type is'START_UP'(not'STARTUP'),optsis optional andkeyis a number.hasteImplModulePathmodules must also exportgetCacheKey().dynamicDepsInPackagesonly applies to files innode_modules; dynamic requires elsewhere are always rejected.getPolyfills([]),processModuleFilter(one module),getRunModuleStatement,schemeResolvers(not nullable),enhanceMiddleware,getTransformOptions(hot: true).assetRegistryPath,enableBabelRuntime(plugin name),rewriteRequestUrl(order relative to middleware),useGlobalHotkey(has no effect),blockList(default hides__tests__),mergeConfig(one level deep; first argument can't be a promise),tls/secureServerOptionsprecedence.symbolicatorsection,resolver.dependencyExtractor,transformer.globalPrefix/allowOptionalDependencies/publicPath,serializer.polyfillModuleNames/customSerializer/experimentalSerializerHookand extragetTransformOptionsfields.unstable_*options not documented before follow in the next change.API, CLI, Getting Started
runServerandcreateConnectMiddlewarehave noportoption;runBuild'soutis optional; corrected how source maps are written and inlined.runServercallsrunMetro, not the other way around; fixed an example using an undefinedhttpServer.devsets__DEV__; production builds inlineprocess.env.NODE_ENVas'production'.loadConfig,runMetro,runBuild(includingoutput),runServer,createConnectMiddleware, and thebuildGraphandattachMetroCliexports.serveoptions and thestartalias, deprecated and ignored flags,get-dependencies [entryFile]and corrected defaults; every--max-workersoverridesmaxWorkers.transform/getCacheKey(options)interface.Resolution and Package Exports
#subpath imports are supported (the docs said they throw)."browser"field and file variant resolution steps, theunstable_conditionsByPlatformfield name, asset variant naming (2x),getPackage/getPackageForModule/asyncTypetypes, resolver caching conditions, and documented missing context fields.Other pages
UNBUNDLElocation; explained startup code and other unexplained terms.HttpCachedoesn't exist; documentedHttpStoreoptions,HttpGetStoreerror handling andAutoCleanFileStore(options).dynamicDepsInPackagesscope, the mappings grammar and the project scaffolding command.Also adds a doc comment to
getMaxWorkers.Changelog: [Internal]
Differential Revision: D125674123