Add FormLayout context awareness to Button - #698
Merged
Conversation
Member
Author
|
👉 Thorough test coverage of |
mbohal
requested changes
Mar 19, 2026
mbohal
approved these changes
Mar 26, 2026
Button now detects FormLayoutContext and applies `isRootInFormLayout` (justify-self: start) and `isRootLayoutHorizontal` (grid-column-start: 2 above md breakpoint), matching the pattern used by all other form fields. Also updates FormLayout README to document Button support and adds Playwright component tests for the new FormLayout integration.
adamkudrna
force-pushed
the
feature/button-in-form-layout
branch
from
March 30, 2026 18:47
d38a4ef to
abdf6f8
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
FormLayoutcontext awareness toButton:Summary
Buttonnow detectsFormLayoutContextand appliesisRootInFormLayout(
justify-self: start) to prevent full-width stretching in both verticaland horizontal layouts
FormLayout,isRootLayoutHorizontalplaces the button inthe field column (
grid-column-start: 2) above themdbreakpoint,aligning it with adjacent form fields
ButtonForFormLayoutTestsstory component andformLayoutvisualtest suite mirroring the pattern from
TextFieldFormLayoutREADME to documentButtonas a supported componentand moves the full-form example to a more prominent place near the top